Fix unpermitted params notices from the backend#854
Open
kevin-atnos wants to merge 1 commit intomasterfrom
Open
Fix unpermitted params notices from the backend#854kevin-atnos wants to merge 1 commit intomasterfrom
kevin-atnos wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix unpermitted params notices on Structures creation, PIA creation and Answer creation when pia is used with pia-back (client/server mode).
The fix filters out id, created_at, and updated_at from being sent to the server during updates. These fields are server-managed and shouldn't be included in API requests.
The fix:
Answer management:
updated both:
- Backend (see PR on pia-back):
- Changed answer_params to permit :data as a string
- Added processed_answer_params that parses the JSON string (same pattern as structures_controller)
- Frontend (pia/src/app/services/answer.service.ts):
- Serialize data as JSON string instead of nested form fields
This follows the same pattern used for structures.