Refactor project dependencies and enhance API documentation - #63
Merged
Conversation
Adds XML docs to all public APIs, refactors AgentInfo to immutable records, introduces AgentFailure/AgentFailover, and adds new value types (SessionStatus, SessionSizeRating, TaskClassification, TestOutcome) with JSON converters and tests. Replaces custom JSON converters with dedicated files. Refactors services for [LoggerMessage] logging, uses collection expressions, and splits WinUI converters. Improves code comments and updates tests/view models for new types. No business logic changes; improves maintainability and API clarity.
auleewilliams
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates and expands unit tests across several components, with a focus on improving coverage for agent state transitions and decision management. It also updates a project dependency and makes minor test refactorings for clarity and correctness.
Unit test improvements and expansions:
AgentInfoTeststo cover the newAgentInfoIdle,AgentInfoRunning, andAgentInfoFailedtypes, including status transitions, error handling, and immutability via with-expressions.DecisionsService, covering creation, listing, retrieval, resolution, error cases, and round-trip parsing of decisions.Test correctness and modernization:
DigestServiceTeststo useDateOnlyfor date parameters and assertions, improving type safety and clarity across multiple test cases. [1] [2] [3] [4] [5] [6] [7]BoardServiceCompleteTaskTeststo use the correctSessionStatusenum instead of a string literal for session status.AgentServiceTeststo assert using the strongly-typedAgentInfoFailedand itsFailureproperty, improving test robustness.LmStudioExecutorTestsby using collection expressions for conciseness.Dependency updates:
Aspire.AppHost.Sdkversion from13.2.4to13.3.0in the main project file.