Skip to content

Add agent skill instructions and repository guidance - #87

Merged
Allann merged 1 commit into
masterfrom
86-make-ads-work-with-codex
Jul 5, 2026
Merged

Add agent skill instructions and repository guidance#87
Allann merged 1 commit into
masterfrom
86-make-ads-work-with-codex

Conversation

@auleewilliams

Copy link
Copy Markdown
Collaborator

Summary

  • Add a broad set of Codex skill definitions under .agents/skills/ for workflows including code review, TDD, triage, frontend design, and Git safety
  • Add supporting guidance files for domain modeling, interview-style workflows, and skill authoring
  • Update the repository-level AGENTS.md with project-specific commands, architecture notes, and testing conventions

Testing

  • Not run (not requested)

@auleewilliams auleewilliams linked an issue May 30, 2026 that may be closed by this pull request
@auleewilliams
auleewilliams requested a review from Allann May 30, 2026 22:42
@auleewilliams auleewilliams self-assigned this May 30, 2026
@auleewilliams auleewilliams added the documentation Improvements or additions to documentation label May 30, 2026

Use the component(s) directly affected. If a commit touches multiple components, list the primary one or use `Multi`.

| Scope | When to use |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should be checking in skills that reference jTrack

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need articles skill?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer grill-with-docs these days. Why should we keep this one?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need this skill either

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the paths in this are wrong, I don't want it using absolute paths. I think all paths should be relative to the project workspace.

|---|---|
| `feature/12345-add-foo` | `12345` |
| `feedback/58340/from-luke` | `58340` |
| `JTD-56566-missing-screen` | `56566` |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned we are leaking JJs articfacts into many of the skills

Comment thread AGENTS.md
@@ -0,0 +1,131 @@
# AGENTS.md

This file provides guidance to Codex (Codex.ai/code) when working with code in this repository.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed Codex being mentioned a lot through some of these skills. We are not currently supporting Codex?

@Allann
Allann merged commit 52f5339 into master Jul 5, 2026
1 check passed
@Allann
Allann deleted the 86-make-ads-work-with-codex branch July 5, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ADS work with Codex

2 participants