Return starting model and config file for delay calibration#101
Return starting model and config file for delay calibration#101
Conversation
lonbar
left a comment
lonbar
left a comment
There was a problem hiding this comment.
Looks good to me. A few minor syntax nits.
| outputSource: | ||
| - generate_skymodels/skymodel | ||
| type: File[] | ||
| pickValue: all_non_null | ||
| linkMerge: merge_flattened |
There was a problem hiding this comment.
| outputSource: | |
| - generate_skymodels/skymodel | |
| type: File[] | |
| pickValue: all_non_null | |
| linkMerge: merge_flattened | |
| outputSource: generate_skymodels/skymodel | |
| type: File[] |
There was a problem hiding this comment.
The source is a single array which is required so the pickValue and linkMerge aren't necessary.
| - id: facetselfcal_config | ||
| outputSource: | ||
| - phaseup/facetselfcal_config | ||
| type: File | ||
| pickValue: all_non_null |
There was a problem hiding this comment.
| - id: facetselfcal_config | |
| outputSource: | |
| - phaseup/facetselfcal_config | |
| type: File | |
| pickValue: all_non_null | |
| - id: facetselfcal_config | |
| outputSource: phaseup/facetselfcal_config | |
| type: File |
|
I'm wondering if it makes sense to bundle outputs such as these into a |
I'm not sure I fully understand. Do you mean in the sense of the contents of these files in a JSON file? |
2 participants
I recently found myself in multiple scenarios where I needed to re-run or tweak the delay calibration on difficult fields. With settings and skymodels now being generated automatically, this is cumbersome at the moment as they are not outputs of the main workflow and as such do not "survive" a successful pipeline run. This PR adds the starting models as outputs of the pipeline as well as the config file that comes from phaseup-concat (the automatic selection does not yet generate config files, I'll leave that for a future PR). This should improve reproducibility in general as well by having easier access to the combination of model and settings that were used.