Fix twilio provider b64encode error in python3#123
Open
Esperk wants to merge 1 commit intoLPgenerator:masterfrom
Open
Fix twilio provider b64encode error in python3#123Esperk wants to merge 1 commit intoLPgenerator:masterfrom
Esperk wants to merge 1 commit intoLPgenerator:masterfrom
Conversation
Author
|
I'm not sure if this is a known issue but the flake8 tests seem to fail on untouched code. |
Author
|
Looks like this is also an issue on #122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following error when running with python3:
TypeError: a bytes-like object is required, not 'str'This change changes nothing in python2 but casts to a bytestring in python3 which enables casting to a base64 string in both versions.