Open
Conversation
Contributor
Author
|
UPDATE: I've been playing with this a bit, and the agreement between the NLA output with the standard CCL method and the output using generalized p_k_a and the PTTracers gets pretty bad for a broad z distribution. This appears to be true even if the input z range for the generalized p_k_a covers the input nz range. Ideas? |
Contributor
|
hey @jablazek is this PR still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly cosmetic, but I had two questions.
Have I correctly treated GI and IG terms for IA? I have explicitly included both, but maybe CCL already does this bookkeeping?
In PerturbationTheoryPk.ipynb, why doesn't the C_ell integrator crash? We set up the IA bias with a max of z=1. Then the lensing tracer goes to z=1.5. What is happening?