Skip to content

fix(slack): resolve slash command timeout and app mention response issues - Fix /translate command: send response to DM instead of channel to avoid timeout - Fix @Signal mentions: respond in channel where mentioned (not DM) for visibility - Add proper error handling for AI failures in translator and catchup - Filter out message edit/delete events to prevent duplicate processing - Improve DM handling to show help menu when users message Signal directly Fixes: - Slack "app did not respond" errors for /translate command - @Signal mentions now respond in-channel with friendly greeting - All slash commands now properly route responses to user DMs#11

Merged
LSUDOKO merged 1 commit into
mainfrom
fix/critical-bugs-worker-ai-translator-focus
Jul 12, 2026

Conversation

@LSUDOKO

@LSUDOKO LSUDOKO commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • /catchup and /translate now deliver help, results, and error messages through direct messages.
    • Slash commands immediately acknowledge requests with a “Working…” response while processing continues.
    • App mentions now provide help directly in the conversation where they were posted.
  • Bug Fixes

    • Improved error handling provides clearer guidance when searches or translation analysis fail.
    • Unsupported message events are ignored safely.
    • Feature processing continues with basic functionality when user setup encounters an issue.

…sues - Fix /translate command: send response to DM instead of channel to avoid timeout - Fix @signal mentions: respond in channel where mentioned (not DM) for visibility - Add proper error handling for AI failures in translator and catchup - Filter out message edit/delete events to prevent duplicate processing - Improve DM handling to show help menu when users message Signal directly Fixes: - Slack "app did not respond" errors for /translate command - @signal mentions now respond in-channel with friendly greeting - All slash commands now properly route responses to user DMs
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 9f94be13-b009-4ebf-9794-fe3f76bc0fdd

📥 Commits

Reviewing files that changed from the base of the PR and between b69c475 and 2f7a245.

📒 Files selected for processing (4)
  • api/internal/features/catchup.go
  • api/internal/features/controller.go
  • api/internal/features/translator.go
  • api/internal/slack/events.go

📝 Walkthrough

Walkthrough

Changes

Slack interaction flow

Layer / File(s) Summary
Event acknowledgement and asynchronous processing
api/internal/slack/events.go
Event requests are acknowledged promptly, unsupported message subtypes are ignored, and interactive or slash-command handling runs asynchronously with copied payloads and cancellation-independent contexts.
Direct-message routing and user provisioning
api/internal/features/controller.go
Direct messages use dedicated help handling, mentions respond in-channel, and user provisioning failures are logged while processing continues.
Catch-up and translation DM responses
api/internal/features/catchup.go, api/internal/features/translator.go
Help, processing errors, and translation results are delivered through user DMs instead of the originating slash-command channel.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Slack
  participant EventHandler
  participant FeatureController
  participant UserDM
  Slack->>EventHandler: Submit slash command
  EventHandler->>Slack: Ack with Working response
  EventHandler->>FeatureController: Process command asynchronously
  FeatureController->>UserDM: Send help, error, or result message
Loading

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands.

@LSUDOKO
LSUDOKO merged commit ad853aa into main Jul 12, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant