Merged
Conversation
modified: package.json new file: src/declarations.d.ts renamed: src/opportunities/components/AboutSection.js -> src/opportunities/components/AboutSection.tsx renamed: src/opportunities/components/AboutSectionElement.js -> src/opportunities/components/AboutSectionElement.tsx modified: src/opportunities/components/HorizontalIconButton.tsx renamed: src/opportunities/components/JobDescription.js -> src/opportunities/components/JobDescription.tsx renamed: src/opportunities/components/JobDetails.js -> src/opportunities/components/JobDetails.tsx renamed: src/opportunities/components/JobHeader.js -> src/opportunities/components/JobHeader.tsx renamed: src/opportunities/components/JobInteractionButton.js -> src/opportunities/components/JobInteractionButton.tsx renamed: src/opportunities/components/JobPost.js -> src/opportunities/components/JobPost.tsx renamed: src/opportunities/components/JobsNavigation.js -> src/opportunities/components/JobsNavigation.tsx modified: src/opportunities/components/SmallTextButton.tsx modified: src/opportunities/pages/IndividualPost.tsx modified: src/shared/components/Checkbox.tsx renamed: src/shared/components/Profile/EditInformation.js -> src/shared/components/Profile/EditInformation.tsx renamed: src/shared/components/Profile/OpportunityActionCard.js -> src/shared/components/Profile/OpportunityActionCard.tsx modified: src/shared/components/SEO.tsx renamed: src/shared/components/UIElements/Backdrop.js -> src/shared/components/UIElements/Backdrop.tsx modified: src/shared/components/UIElements/Breadcrumb.tsx deleted: src/shared/components/UIElements/GroupedComponents.js new file: src/shared/components/UIElements/GroupedComponents.tsx modified: src/shared/components/UIElements/LargeTextCard.tsx modified: src/shared/hooks/page-navigation-hook.ts renamed: src/shared/pages/EditProfile.js -> src/shared/pages/EditProfile.tsx modified: src/staff/components/DepartmentStaff.tsx renamed: src/staff/components/Input.js -> src/staff/components/Input.tsx renamed: src/staff/components/LargeImageCard.js -> src/staff/components/LargeImageCard.tsx modified: src/style/general.css
modified: src/opportunities/pages/IndividualPost.tsx
modified: src/opportunities/components/JobDescription.tsx modified: src/shared/components/Profile/EditInformation.tsx modified: src/staff/components/Input.tsx
Contributor
Author
|
The last couple issues with eslint is stuff carried over from re branching from main, not sure if you want me to fix it since I'll be deleting the unused vars and im guessing they were added for something that isnt finished. The role defined and not used is for the department prop of Avatar, added a role prop to clear an error but wasn't sure if I should just delete the department getting passed in in Job Header since I saw department props got adding to a couple other components between my PRs. Lmk if you want me to make any other changes. Also made a couple changes to the fetch request on my end but I wanna wait to PR them until I can test them more. |
RafaelCenzano
approved these changes
May 1, 2025
|
|
||
|
|
||
| const fetchOpportunities = async () => { | ||
| const fetchOpportunities = useCallback(async () => { |
Member
There was a problem hiding this comment.
good thinking, this should help reduce calls to the backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified: src/opportunities/pages/IndividualPost.tsx
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Running npm start and checking frontend display
Checklist: