configured github flows and CI actions#118
configured github flows and CI actions#118ekumamatthew wants to merge 11 commits intoLabsCrypt:mainfrom
Conversation
ogazboiz
left a comment
There was a problem hiding this comment.
Thanks for setting up the CI pipeline! This is a great step for the project. I have a few suggestions to make it more robust:
- Test Script Resilience: Currently, in the backend will fail because the script is just an error placeholder. I suggest using or updating the package.json to have a basic test setup.
- Linting: It would be great to add a linting step (e.g., ) to ensure consistent code style across PRs.
- Workflow Name: 'Test Suite' is clear, but maybe 'CI / Validation' would be even better as we add more checks.
Overall, great work! Looking forward to the next iteration.
ogazboiz
left a comment
There was a problem hiding this comment.
Thanks for the PR. This has conflicts with main. Please resolve them. Also, use 'npm test --if-present' to avoid CI failure when tests are missing.
ogazboiz
left a comment
There was a problem hiding this comment.
Thanks for setting up the CI pipeline! I've recently merged several PRs that refactored the backend to use 'vitest' and changed the architecture to an 'app.ts' model.
Currently, this PR has conflicts and introduces 'jest' which is now redundant for the backend. Could you please:
- Rebase on the latest 'main'.
- Align the CI workflow with the new 'npm install' and 'vitest' setup.
- Remove the redundant 'jest' configurations for the backend.
Looking forward to the updated CI! 🚀
|
okay I'll do that now. I'm just seeing this |
ogazboiz
left a comment
There was a problem hiding this comment.
Following up on my earlier review: our main branch now uses vitest for the backend (see merged #112). Please update your CI workflow to use npm test (which runs vitest) instead of configuring jest. Also, note that react-hot-toast was just added as a root dependency in #145 — please pull the latest main before rebasing to avoid lockfile conflicts. Looking forward to the updated CI! 🚀
ogazboiz
left a comment
There was a problem hiding this comment.
Third review follow-up: we have now merged #145 (react-hot-toast) and #147 (security policy + CodeQL). The CI workflow needs to: 1) use npx vitest run or npm test (mapped to vitest in package.json) for backend tests, not Jest 2) update the package-lock.json reference for the new dependencies. Please rebase on the latest main before updating the workflow to avoid lockfile conflicts.
ogazboiz
left a comment
There was a problem hiding this comment.
Third review follow-up: our main branch now uses vitest for the backend (see merged #112). Please update your CI workflow to use npm test (which runs vitest) instead of configuring jest. Also, note that we recently merged several PRs that updated dependencies — please rebase on the latest main to avoid lockfile conflicts.
|
i have just sync my fork to get the latest update.. I am looking through to remove jest and use vitest |
|
hi @ogazboiz i have made Some fixes.. have a look |
ogazboiz
left a comment
There was a problem hiding this comment.
hey, thanks for the updates!
i just checked it out, but it looks like the PR still has merge conflicts with main because it's coming from your main branch. to get this merged, you'll need to rebase it: git fetch origin && git rebase origin/main and resolve any conflicts.
also, our test runner has moved from jest to vitest — the backend test command is now simply npm test. could you double check that the CI workflow file is using vitest? let me know when you've pushed the rebased version!
Hi. I have done what i can with the CI intergration.. i have rebase and merge to current changes, please can you look into it. maybe its a little fix i'm not seeing . |
ogazboiz
left a comment
There was a problem hiding this comment.
hey, thanks for updating!
the .github/workflows/test.yml structure looks good now. however, there's a bun.lockb file in the diff, which means you probably used bun install locally. the project uses npm exclusively right now, and having both lockfiles will confuse the CI parser.
could you run these commands to fix it?
git rm bun.lockb
npm minstall
git add package-lock.json frontend/package-lock.json backend/package-lock.json
git commit -m "use npm lockfile instead of bun"
git pushonce the bun lockfile is gone, the CI should run successfully and we can merge this in!
Okay I will do that right now |
ogazboiz
left a comment
There was a problem hiding this comment.
hey! just checking in on this one.
since we've had several other CI/Action PRs land recently, could you check if this is still providing a unique fix or if it's now redundant? also, the tests are currently failing, so it might need a rebase anyway.
if it's no longer needed, feel free to close it — otherwise, let us know once it's rebased and green!
this PR closes #80
created a comprehensive CI/CD workflow for the FlowFi project that prevents regressions on every push to main:
What Was Built
Test Coverage
Key Features