feat: implement dedicated wallet selection modal interface#174
Conversation
ogazboiz
left a comment
There was a problem hiding this comment.
hey, thanks for working on the wallet selection modal!
just a heads up: we actually just merged a large 'Production ready wallet integrations' epic (PR #163) which also added wallet modal components and modified the same files (Navbar.tsx, etc). because of that, this PR now has merge conflicts with main.
could you please run git fetch origin && git rebase origin/main to resolve the conflicts? this will also let you see the newly merged wallet components — you might need to adapt your changes to fit the new structure.
let us know once you've rebased and we'll take another look!
2215845 to
fbd8d10
Compare
ogazboiz
left a comment
There was a problem hiding this comment.
hey! thanks for the UI work on the wallet selection modal.
caught a bit of scope creep in your PR though — it looks like you modified .github/workflows/ci.yml. we already merged a major wallet integration PR yesterday (#163) which touched some of these areas.
could you please rebase on main, remove the unrelated changes to the CI workflow, and check if your modal still blends well with the new wallet components from #163?
also, CI is currently failing, so fixing that rebase should help clear things up!
ogazboiz
left a comment
There was a problem hiding this comment.
hey, thanks for the contribution!
just had a look at this — the backend and frontend CI checks are currently failing and there are merge conflicts with main.
could you pull the latest changes, resolve the conflicts, and take a look at the workflow logs under the "Checks" tab to fix the failing steps?
once that's sorted let us know and we'll take another look — happy to help if you get stuck! if you want to contribute more or follow up if issues are open, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
ogazboiz
left a comment
There was a problem hiding this comment.
hey, thanks for the contribution!
To ensure your Pull Request passes the CI pipeline and maintains repository stability, please follow these technical requirements:
1. Backend Testing (Vitest)
- Version: We have standardized on Vitest
^2.1.8. Do not upgrade to v3 or v4 without explicit approval, as they introduce native dependency issues in the CI environment. - Isolation: Each test file now runs in its own forked process (
pool: 'forks'). This preventsvi.mock()and other module-level states from leaking between files. - Prisma Mocking: When testing controllers, always mock the Prisma client in
backend/src/lib/prisma.ts. Do not rely on a real database for unit tests. - CLI Flags: Avoid using the
--verboseflag in Vitest commands, as it is incompatible with the v2 CLI.
2. API Versioning & Routing
- Endpoints: Hit versioned endpoints (e.g.,
/v1/streams) instead of the deprecated root endpoints (e.g.,/streams). - Response Codes: Endpoints return
410 Gonefor specifically deprecated routes. Ensure your tests handle these correctly. - Input Validation: Controllers expect strict field names (e.g.,
streamId,ratePerSecond,depositedAmount). Use the types defined insrc/services/andsrc/controllers/.
3. Infrastructure & Dependencies
- Husky: The pipeline skips Husky. Your
package.jsonscripts should usehusky || trueto prevent non-interactive shell failures. - Prisma Generation: Always ensure your workflow runs
prisma generatebefore tests. The CI now handles this in a consolidated "Setup Database" step. - Native Bindings: If you add dependencies with native bindings (like Rollup or ESBuild), ensure they are compatible with the
ubuntu-latest(linux-x64) runner.
4. Frontend Best Practices
- Directives: Always include
"use client"at the top of components that utilize React hooks or browser APIs. - Dependencies: Ensure all utilized libraries (like
react-hot-toast) are explicitly added tofrontend/package.jsonand not just inherited from the root.
Please make sure your CI passes before we finalize the merge. Let us know if you have any questions!
If you want to follow up or have questions, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
- Added Albedo and xBull to SUPPORTED_WALLETS array - Implemented mock connection functions for Albedo and xBull wallets - Updated WalletModal to display all three wallets with wallet-specific notes - Updated footer to show all supported wallets - Fixed lint warnings in wallet-entry and WalletButton components
f0c0103 to
1c17cc1
Compare
|
You can check now @ogazboiz |
ogazboiz
left a comment
There was a problem hiding this comment.
looks great, merging this in! thanks for the contribution.
if you want to contribute more or follow up if issues are open, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
closes #67
Description
Features:
Screenshot of the implementation of the design modal
