Add Proposal Expiry to MultisigGovernance (#436)#516
Add Proposal Expiry to MultisigGovernance (#436)#516mijinummi wants to merge 2 commits intoLabsCrypt:mainfrom
Conversation
|
The contracts CI is failing on the rustfmt format check. This isn't a logic issue, just formatting. Run this in the contracts directory and push: cd contracts
cargo fmtThen commit and push the formatting changes. The CI should pass after that. |
ogazboiz
left a comment
There was a problem hiding this comment.
Contracts CI is failing under 30 seconds, which is almost always a cargo fmt check. Run this from the contracts/ directory and commit the result:
cd contracts
cargo fmt
git add -A
git commit -m 'style: apply cargo fmt'
git push|
The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience. |
ogazboiz
left a comment
There was a problem hiding this comment.
The code appends a second #[ink(storage)] struct and impl block to the existing file, which is a compilation error. This contract is Soroban, not ink!. Self::env().block_number() won't compile in a non-self function. String errors should be a proper error enum. Please integrate into the existing contract structure instead of appending a separate one.
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
📝 Description
Overview
This PR adds proposal expiry logic to the MultisigGovernance contract.
Key Features
expires_atfield on proposalscancel_expired_proposalcleans up stale proposalsCloses #436