fix: emit ProposalApproved event with proposal_id and add coverage tests

[Vvictor-commits]

Closes #485

[ogazboiz]

The contracts CI is failing on the rustfmt format check. This isn't a logic issue, just formatting.

Run this in the contracts directory and push:

cd contracts
cargo fmt

Then commit and push the formatting changes. The CI should pass after that.

[ogazboiz]

No CI checks are running on this branch. The CI workflows run on pushes to branches with open PRs, but nothing is showing up here.

Can you check if the branch was pushed correctly? Try pushing a small change (even whitespace) to trigger the CI. We need contracts and backend CI to be green before merging.

[Vvictor-commits]

i've done it please check

[ogazboiz]

hey @Vvictor-commits, the ProposalApproved event emission and coverage tests look like a useful addition. no CI checks ran though, so I can't verify the build passes.

could you push an empty commit to trigger CI?

git commit --allow-empty -m "chore: trigger CI"
git push

once CI is green we can do a proper review!

[ogazboiz]

hey @Vvictor-commits, still no CI checks showing on this PR. the empty commit approach may not have worked. could you try force-pushing or making a small code change to trigger the workflows?

git commit --allow-empty -m "chore: trigger CI"
git push

if CI was passing in your local environment, the code looks good from my side. just need to see it pass in GitHub Actions before we merge.

[ogazboiz]

The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience.

[ogazboiz]

Logic is good. Event emission and tests are well written. One issue: the TransferApprovedEvent struct has a new proposal_id field but is no longer used in the publish() call (which switched to a tuple). The struct is now dead code, either remove it or use it. Also push an empty commit to trigger CI since no checks have ever run.

[ogazboiz]

Hey, just checking in. Have you had a chance to look at the review feedback? Let me know if you need any help or have questions about the requested changes.

[Vvictor-commits]

i'm so confused about what exactly im to do

[ogazboiz]

heads up, a few important changes just landed on main that affect your PR:

1. axios pinned to 1.13.5 - there's an active supply chain attack on axios 1.14.1 (pulls in confirmed malware). we added overrides in all package.json files to block it.

2. CI now runs a supply chain audit before backend/frontend jobs. if your lockfile has a compromised package, CI will fail with a clear error.

3. backend test fixes - loanEndpoints tests now use valid Stellar addresses and base64 strings. if your PR was failing backend CI but you didn't touch backend code, this should fix it after rebase.

please rebase on latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

[Vvictor-commits]

please check again

[ogazboiz]

hey @Vvictor-commits, still no CI checks showing. the dead code issue (TransferApprovedEvent struct) also still needs to be addressed. try making a small whitespace change and pushing to trigger CI, then remove or use the unused struct.

[Vvictor-commits]

@ogazboiz please review

[ogazboiz]

hey @Vvictor-commits, checked again. the TransferApprovedEvent struct is still in the diff and still unused. CI is also showing action_required which means it's not passing. please remove the unused struct and push again to trigger CI. once both are fixed we can merge.