Conversation
…gPool, and RemittanceNFT
|
The contracts CI is failing on the rustfmt format check. This isn't a logic issue, just formatting. Run this in the contracts directory and push: cd contracts
cargo fmtThen commit and push the formatting changes. The CI should pass after that. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ogazboiz
left a comment
There was a problem hiding this comment.
hey @nonso7, the diff on this PR is over 20,000 lines which is way too large for a single review. could you break this into smaller, focused PRs? for example:
- one PR for the share-based accounting contract changes
- one PR for the test updates
- one PR for any frontend/backend integration
massive PRs are really hard to review properly and tend to sit open for a long time. smaller ones get merged faster.
also, no CI checks ran on this branch. you'll want to trigger a fresh run after splitting.
|
The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience. |
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
Closes #355