Skip to content

Feature/share based accounting#527

Open
nonso7 wants to merge 7 commits intoLabsCrypt:mainfrom
nonso7:feature/share-based-accounting
Open

Feature/share based accounting#527
nonso7 wants to merge 7 commits intoLabsCrypt:mainfrom
nonso7:feature/share-based-accounting

Conversation

@nonso7
Copy link
Copy Markdown

@nonso7 nonso7 commented Mar 29, 2026

Closes #355

@ogazboiz
Copy link
Copy Markdown
Contributor

The contracts CI is failing on the rustfmt format check. This isn't a logic issue, just formatting.

Run this in the contracts directory and push:

cd contracts
cargo fmt

Then commit and push the formatting changes. The CI should pass after that.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nonso7, the diff on this PR is over 20,000 lines which is way too large for a single review. could you break this into smaller, focused PRs? for example:

  • one PR for the share-based accounting contract changes
  • one PR for the test updates
  • one PR for any frontend/backend integration

massive PRs are really hard to review properly and tend to sit open for a long time. smaller ones get merged faster.

also, no CI checks ran on this branch. you'll want to trigger a fresh run after splitting.

@ogazboiz
Copy link
Copy Markdown
Contributor

The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience.

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same blockers as #525: rebase, renumber migrations above 1783000000013, remove debug files. Shares identical backend changes with #525, so one should merge first and the other rebase on top.

@ogazboiz
Copy link
Copy Markdown
Contributor

heads up, a few important changes just landed on main that affect your PR:

  1. axios pinned to 1.13.5 - there's an active supply chain attack on axios 1.14.1 (pulls in confirmed malware). we added overrides in all package.json files to block it.

  2. CI now runs a supply chain audit before backend/frontend jobs. if your lockfile has a compromised package, CI will fail with a clear error.

  3. backend test fixes - loanEndpoints tests now use valid Stellar addresses and base64 strings. if your PR was failing backend CI but you didn't touch backend code, this should fix it after rebase.

please rebase on latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Contract] LendingPool — No Share-Based Accounting (Deposit/Withdraw Use Raw Amounts)

2 participants