#589 feat(frontend): add tooltip explanations for financial terms (AP…#598
#589 feat(frontend): add tooltip explanations for financial terms (AP…#598Feyisara2108 wants to merge 5 commits intoLabsCrypt:mainfrom
Conversation
|
Two things to fix: 1. Frontend — layout.tsx conflict The PR adds Please rebase on main first, then add 2. Backend — eventIndexer.test.ts This test was added in the recent #595 merge and it's failing on your branch. It's not caused by your changes — you just need to rebase on main to pick up the updated Once you rebase, both failures should clear up. The actual tooltip work looks solid. |
…terms (APY, utilization rate, credit score) # Conflicts: # frontend/src/app/layout.tsx
687d7ec to
5c85b44
Compare
ogazboiz
left a comment
There was a problem hiding this comment.
Frontend Prettier check is failing. Run this from the frontend/ directory and commit:
cd frontend
npx prettier --write .
git add -A
git commit -m 'style: apply prettier formatting'
git pushAlso rebase on main afterward to pick up a recent test fix in eventIndexer.test.ts.
|
The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience. |
ogazboiz
left a comment
There was a problem hiding this comment.
Root-level package-lock.json was committed by accident (dependencies should go in frontend/package.json). Unused HelpCircle import. The cn() utility may already exist in the project, check before duplicating it. Has merge conflicts. Fix and rebase.
|
Hey, just checking in. Have you had a chance to look at the review feedback? Let me know if you need any help or have questions about the requested changes. |
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
#589 feat(frontend): add tooltip explanations for financial terms (APY, utilization rate, credit score)
Summary
Adds a reusable, accessible Tooltip component and integrates plain-English explanations for key financial terms to improve onboarding for non-finance-savvy users.
Changes
src/components/ui/Tooltip.tsx: reusable, accessible tooltip with hover/focus supportrole="tooltip",aria-describedby) for screen reader supportAccessibility
aria-describedbylinking for screen readersTesting
Screenshots (Optional)
[Attach if helpful]
Issue
Closes #589