Skip to content

feat(frontend): add CSV export for wallet and loan records#608

Open
Feyisara2108 wants to merge 2 commits intoLabsCrypt:mainfrom
Feyisara2108:feat/586-csv-export
Open

feat(frontend): add CSV export for wallet and loan records#608
Feyisara2108 wants to merge 2 commits intoLabsCrypt:mainfrom
Feyisara2108:feat/586-csv-export

Conversation

@Feyisara2108
Copy link
Copy Markdown

#586
closed

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend Prettier check is failing. Run this from the frontend/ directory and commit:

cd frontend
npx prettier --write .
git add -A
git commit -m 'style: apply prettier formatting'
git push

Also rebase on main afterward to pick up a recent test fix in eventIndexer.test.ts.

@ogazboiz
Copy link
Copy Markdown
Contributor

The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience.

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has merge conflicts. Same unrelated backend test changes as #605. The getLoanAsset function falls back to "USD" which is wrong if the loan is in XLM or another Stellar asset. The CSV utility itself is solid (BOM prefix, proper escaping). Fix conflicts and remove unrelated backend changes.

@ogazboiz
Copy link
Copy Markdown
Contributor

heads up, a few important changes just landed on main that affect your PR:

  1. axios pinned to 1.13.5 - there's an active supply chain attack on axios 1.14.1 (pulls in confirmed malware). we added overrides in all package.json files to block it.

  2. CI now runs a supply chain audit before backend/frontend jobs. if your lockfile has a compromised package, CI will fail with a clear error.

  3. backend test fixes - loanEndpoints tests now use valid Stellar addresses and base64 strings. if your PR was failing backend CI but you didn't touch backend code, this should fix it after rebase.

please rebase on latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants