Conversation
useSSE.ts — a React hook, purely client-side setInterval polling fallback — browser JavaScript LabsCrypt#577
ogazboiz
left a comment
There was a problem hiding this comment.
hey @onyillto, CI is failing. backend and frontend builds are both red. check the workflow logs and fix the issues.
the PR title "Update useSSE.ts" is also pretty minimal. could you add a description of what you changed and why? makes it much easier to review.
fix CI and update the description, then we'll take a look!
|
The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience. |
ogazboiz
left a comment
There was a problem hiding this comment.
Code change is good. The polling fallback in useSSE is solid with proper cleanup. PR title is too generic ("Update useSSE.ts"), should describe the feature. Check why CI is unstable (likely unrelated). Would approve after title fix and rebase.
|
Hey, just checking in. Have you had a chance to look at the review feedback? Let me know if you need any help or have questions about the requested changes. |
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
useSSE.ts — a React hook, purely client-side
setInterval polling fallback — browser JavaScript
#577