Skip to content

Update useSSE.ts#622

Open
onyillto wants to merge 6 commits intoLabsCrypt:mainfrom
onyillto:add-polling-back
Open

Update useSSE.ts#622
onyillto wants to merge 6 commits intoLabsCrypt:mainfrom
onyillto:add-polling-back

Conversation

@onyillto
Copy link
Copy Markdown

useSSE.ts — a React hook, purely client-side
setInterval polling fallback — browser JavaScript

#577

useSSE.ts — a React hook, purely client-side
setInterval polling fallback — browser JavaScript

LabsCrypt#577
Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @onyillto, CI is failing. backend and frontend builds are both red. check the workflow logs and fix the issues.

the PR title "Update useSSE.ts" is also pretty minimal. could you add a description of what you changed and why? makes it much easier to review.

fix CI and update the description, then we'll take a look!

@ogazboiz
Copy link
Copy Markdown
Contributor

The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience.

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is good. The polling fallback in useSSE is solid with proper cleanup. PR title is too generic ("Update useSSE.ts"), should describe the feature. Check why CI is unstable (likely unrelated). Would approve after title fix and rebase.

@ogazboiz
Copy link
Copy Markdown
Contributor

Hey, just checking in. Have you had a chance to look at the review feedback? Let me know if you need any help or have questions about the requested changes.

@ogazboiz
Copy link
Copy Markdown
Contributor

heads up, a few important changes just landed on main that affect your PR:

  1. axios pinned to 1.13.5 - there's an active supply chain attack on axios 1.14.1 (pulls in confirmed malware). we added overrides in all package.json files to block it.

  2. CI now runs a supply chain audit before backend/frontend jobs. if your lockfile has a compromised package, CI will fail with a clear error.

  3. backend test fixes - loanEndpoints tests now use valid Stellar addresses and base64 strings. if your PR was failing backend CI but you didn't touch backend code, this should fix it after rebase.

please rebase on latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants