Conversation
|
The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience. |
|
Just following up on this. The code in this PR uses ink!/Substrate framework macros but the project uses Soroban. These are incompatible frameworks. I'd recommend closing this PR and opening a new one that integrates with the existing Soroban contract structure instead. |
|
Okay, thanks for your recommendation. |
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
…emove Ink! code from Soroban contract
|
Hello @ogazboiz , have made the rebasse successfully and other fixing. Please kindly review |
|
hey @mijinummi, thanks for the rebase but the core issue is still there. this PR adds ink!/Substrate code to a Soroban project, which are incompatible frameworks. the changes can't work in this codebase. closing this one. if you want to contribute to the contracts, check the existing Soroban patterns in join us on Telegram if you want to discuss: https://t.me/+DOylgFv1jyJlNzM0 |
|
I'm surprised seeing this, I've ensured that I've removed the ink which I mistakenly used inside the indexer file. Could you please clarify this? I needed more information on why closing this after the fixing |
fix rustfmt checking