Skip to content

Fix/cargo fmt#670

Closed
mijinummi wants to merge 3 commits intoLabsCrypt:mainfrom
mijinummi:fix/cargo-fmt
Closed

Fix/cargo fmt#670
mijinummi wants to merge 3 commits intoLabsCrypt:mainfrom
mijinummi:fix/cargo-fmt

Conversation

@mijinummi
Copy link
Copy Markdown

fix rustfmt checking

@ogazboiz
Copy link
Copy Markdown
Contributor

The codebase issues on main have been resolved and all CI checks are passing now. Please rebase your branch to pull in the latest changes before continuing. Thanks for your patience.

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the branch name "fix/cargo-fmt", this PR adds 123 lines of ink!/Substrate code to a Soroban contract. Same incompatible framework issue as #662. The title is misleading. Should be closed.

@ogazboiz
Copy link
Copy Markdown
Contributor

Just following up on this. The code in this PR uses ink!/Substrate framework macros but the project uses Soroban. These are incompatible frameworks. I'd recommend closing this PR and opening a new one that integrates with the existing Soroban contract structure instead.

@mijinummi
Copy link
Copy Markdown
Author

Okay, thanks for your recommendation.

@ogazboiz
Copy link
Copy Markdown
Contributor

heads up, a few important changes just landed on main that affect your PR:

  1. axios pinned to 1.13.5 - there's an active supply chain attack on axios 1.14.1 (pulls in confirmed malware). we added overrides in all package.json files to block it.

  2. CI now runs a supply chain audit before backend/frontend jobs. if your lockfile has a compromised package, CI will fail with a clear error.

  3. backend test fixes - loanEndpoints tests now use valid Stellar addresses and base64 strings. if your PR was failing backend CI but you didn't touch backend code, this should fix it after rebase.

please rebase on latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease

@mijinummi
Copy link
Copy Markdown
Author

Hello @ogazboiz , have made the rebasse successfully and other fixing. Please kindly review

@ogazboiz
Copy link
Copy Markdown
Contributor

hey @mijinummi, thanks for the rebase but the core issue is still there. this PR adds ink!/Substrate code to a Soroban project, which are incompatible frameworks. the changes can't work in this codebase.

closing this one. if you want to contribute to the contracts, check the existing Soroban patterns in contracts/ and feel free to pick up an open issue.

join us on Telegram if you want to discuss: https://t.me/+DOylgFv1jyJlNzM0

@ogazboiz ogazboiz closed this Mar 31, 2026
@mijinummi
Copy link
Copy Markdown
Author

I'm surprised seeing this, I've ensured that I've removed the ink which I mistakenly used inside the indexer file. Could you please clarify this?

I needed more information on why closing this after the fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants