Conversation
created the useSSE hook and ensure the UI correctly reflects the connection state.
|
closes: #577 |
ogazboiz
left a comment
There was a problem hiding this comment.
This hook already exists in the codebase at hooks/useSSE. Adding a second copy in components/providers/ creates duplicate code. Also the file placement doesn't match the project convention (hooks go in the hooks/ directory). I'd recommend closing this PR.
ogazboiz
left a comment
There was a problem hiding this comment.
hey, I see this closes #577 but the useSSE hook already exists in the codebase at hooks/useSSE.ts. adding a second copy in components/providers/ would create two competing versions of the same thing.
if the existing hook is missing the polling fallback from #577, the better approach would be to update the existing hook in-place rather than creating a new file. that way there's one source of truth. want to take that approach instead?
|
hey, I see this closes #577 but the useSSE hook already exists in the codebase at hooks/useSSE.ts. adding a second copy in components/providers/ would create two competing versions of the same thing. if the existing hook is missing the polling fallback from #577, the better approach would be to update the existing hook in-place rather than creating a new file. that way there's one source of truth. want to take that approach instead? |
|
heads up, a few important changes just landed on main that affect your PR:
please rebase on latest main: git fetch upstream
git rebase upstream/main
git push --force-with-lease |
created the useSSE hook and ensure the UI correctly reflects the connection state.