Fix interest accrual calculation for loan_manager contract#688
Open
Dherah-77 wants to merge 15 commits intoLabsCrypt:mainfrom
Open
Fix interest accrual calculation for loan_manager contract#688Dherah-77 wants to merge 15 commits intoLabsCrypt:mainfrom
Dherah-77 wants to merge 15 commits intoLabsCrypt:mainfrom
Conversation
ogazboiz
requested changes
Apr 5, 2026
Contributor
ogazboiz
left a comment
There was a problem hiding this comment.
hey, contracts CI is failing on cargo fmt. please run this and push:
cd contracts
cargo fmt --all
git add -A
git commit -m "fix: cargo fmt"
git push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #456
This PR fixes an issue with the interest accrual logic in the loan_manager contract to ensure accurate and consistent calculation of interest over time.
Corrected the interest accrual formula to align with expected financial logic
Fixed scaling/precision handling to avoid incorrect values
Updated relevant functions to ensure proper accumulation of interest
Improved test coverage for interest-related scenarios
Ran cargo test successfully
All existing and updated tests passed
Verified correctness of interest calculations through test cases