Bring Java bindings up to C API parity#4
Merged
Conversation
3397253 to
ad5dcb4
Compare
ad5dcb4 to
9c934f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the Java bindings closer to the current C API and Go cgo binding surface:
Notes
lbugDatabaseInitExtendedis intentionally temporary so this Java checkout can run against currently published native artifacts while new main-repo artifacts catch up. A TODO is included next to the native declaration to fold it back intolbugDatabaseInitafter artifacts are rebuilt.Validation
SKIP_CMAKE_BUILD=true ./gradlew compileJava compileTestJavaclang++ -std=c++20 -fsyntax-only ... src/jni/lbug_java.cppdownload-native-libs.shagainst upstream run26604242869on macOS arm64