ci: disable wasm httpfs static link#545
Merged
Merged
Conversation
Contributor
Author
|
This is a revert of #540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily disables static linking of the
httpfsextension in the wasm package build.Context
The wasm build started failing after
httpfswas added toEXTRA_CMAKE_FLAGSbecause the extension needs OpenSSL support. Initial attempts to satisfy that dependency showed that the available prebuilt wasm OpenSSL package is not compatible withcpp-httplibsocket BIO usage, so this rolls wasm back to the previously working extension set while we sort out the right OpenSSL/httpfs approach.Validation
git diff --check