Skip to content

[wip] upgrade Hyrax, add Valkyrie-based Resources for works#1132

Open
rococodogs wants to merge 308 commits into
developfrom
valkyrie-resources
Open

[wip] upgrade Hyrax, add Valkyrie-based Resources for works#1132
rococodogs wants to merge 308 commits into
developfrom
valkyrie-resources

Conversation

@rococodogs

@rococodogs rococodogs commented Jul 30, 2024

Copy link
Copy Markdown
Member

okay wow this really blew up:

  • upgrades aplenty: hyrax -> 4, rails -> 6, ruby -> 3 (and the resulting cascade of dependency updates including bootstrap -> 4)
  • adds valkyrie-based Resources for Curation Concern worktypes (Publication, Image, StudentWork, AudioVisual) and updates existing code to use newer Hyrax conventions.

currently still wip as the view partials all need to be updated for bootstrap 4.

@rococodogs

Copy link
Copy Markdown
Member Author

commenting for posterity: the tests all pass for me locally, github has been v. finicky with this pr

@codecov

codecov Bot commented Jan 8, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 98.24%. Comparing base (a27748b) to head (c46abbd).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...orms/concerns/spot/forms/identifier_form_fields.rb 68.96% 9 Missing ⚠️
...orms/batch_edit_form_terms_and_permitted_params.rb 50.00% 5 Missing ⚠️
...ollections_dashboard_controller_facets_behavior.rb 66.66% 3 Missing ⚠️
...orms/concerns/spot/forms/resource_form_behavior.rb 75.00% 2 Missing ⚠️
app/forms/student_work_resource_form.rb 92.00% 2 Missing ⚠️
app/indexers/base_indexer.rb 81.81% 2 Missing ⚠️
app/services/spot/embargo_lease_service.rb 90.90% 2 Missing ⚠️
app/services/spot/work_form_service.rb 66.66% 2 Missing ⚠️
...concerns/spot/qa_assign_fast_subauthority_patch.rb 87.50% 1 Missing ⚠️
app/controllers/concerns/spot/one_column_layout.rb 80.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1132      +/-   ##
===========================================
- Coverage    98.75%   98.24%   -0.51%     
===========================================
  Files          192      225      +33     
  Lines         3364     3812     +448     
===========================================
+ Hits          3322     3745     +423     
- Misses          42       67      +25     
Files with missing lines Coverage Δ
app/actors/concerns/deserializes_rdf_literals.rb 100.00% <100.00%> (ø)
app/actors/solr_suggest_actor.rb 100.00% <ø> (ø)
...actors/spot/actors/collections_membership_actor.rb 100.00% <ø> (ø)
...rns/spot/qa_assign_fast_generic_authority_patch.rb 100.00% <100.00%> (ø)
app/controllers/application_controller.rb 92.85% <ø> (-0.25%) ⬇️
app/controllers/catalog_controller.rb 100.00% <100.00%> (ø)
...ollers/concerns/spot/cas_entitlement_patch_rack.rb 100.00% <100.00%> (ø)
...ers/concerns/spot/downloads_controller_behavior.rb 100.00% <100.00%> (ø)
...rollers/concerns/spot/works_controller_behavior.rb 100.00% <100.00%> (+15.78%) ⬆️
app/controllers/handle_controller.rb 100.00% <100.00%> (+6.25%) ⬆️
... and 82 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rococodogs

Copy link
Copy Markdown
Member Author

ok after going through every ENV possibility, i think the create_*_specs are failing because of something to do with the VALKYRIE_SOLR_CORE variable? it's working with the development core but not the test one?

@rococodogs rococodogs changed the title [wip] use Valkyrie-based Resources for works use Valkyrie-based Resources for works Mar 11, 2025
@rococodogs rococodogs marked this pull request as ready for review March 11, 2025 15:29
@rococodogs rococodogs changed the title use Valkyrie-based Resources for works add Valkyrie-based Resources for works Mar 11, 2025
@rococodogs rococodogs changed the title add Valkyrie-based Resources for works [wip] upgrade Hyrax, add Valkyrie-based Resources for works Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants