Auto revamp#72
Open
Murat65536 wants to merge 15 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the autonomous mode selection to use a richer enum (AutonChoice) with per-choice display names and construction logic, and updates the generated UML diagrams accordingly.
Changes:
- Replace
AutonChoiceswithAutonChoiceand move auton construction behind a factory-backed enum method. - Populate the
SendableChooserfromAutonChoice.values()instead of hardcoding options. - Update UML diagrams/relationships to reflect the new auton selection types.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/frc/robot/autons/AutonSelector.java | Introduces AutonChoice enum with display names + factory method; updates chooser initialization and selection logic. |
| src/main/java/frc/robot/subsystems/Dashboard.java | Updates chooser generic type/import to AutonChoice. |
| src/uml/uml.mmd | Updates overall generated class diagram entries for auton selection refactor. |
| src/uml/relationships.mmd | Updates auton selection relationships to AutonChoice / AutonFactory. |
| src/uml/frc/robot/subsystems/Dashboard.mmd | Updates UML for Dashboard chooser type change. |
| src/uml/frc/robot/autons/AutonSelector.mmd | Updates UML for AutonSelector chooser type change. |
| src/uml/frc/robot/autons/AutonFactory.mmd | Adds UML entry for the auton factory interface. |
| src/uml/frc/robot/autons/AutonChoices.mmd | Removes old UML enum for AutonChoices. |
| src/uml/frc/robot/autons/AutonChoice.mmd | Adds UML entry for the new AutonChoice enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
reediculous456
left a comment
reediculous456
left a comment
There was a problem hiding this comment.
copilot has several important comments that need to be addressed
reediculous456
approved these changes
Mar 31, 2026
Member
reediculous456
left a comment
reediculous456
left a comment
There was a problem hiding this comment.
Approved but we shouldn't merge this without extensive testing and probably not until after MVR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue Number
Comments