update(upbit): update the address of document site for all Unified API#19
update(upbit): update the address of document site for all Unified API#19
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @LambdaBen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the documentation links for the Upbit exchange in the ts/src/upbit.ts file. It updates the Korean documentation links to the latest versions and adds links to the global documentation where available. This ensures that users have access to the most up-to-date and relevant documentation for the Upbit exchange.
Highlights
- Documentation Update: The primary focus of this PR is to update the documentation URLs for the Upbit exchange within the codebase.
- Korean Documentation: The pull request updates the Korean documentation links to the most recent versions.
- Global Documentation: The pull request adds links to the global documentation for Upbit, providing users with more comprehensive resources.
Changelog
Click here to see the changelog
- ts/src/upbit.ts
- Updated documentation URL for
fetchMarketsto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchBalanceto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchOrderBooksto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchOrderBookto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchTickersto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchTickerto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchTradesto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchTradingFeeto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchOHLCVto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
createOrderto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
cancelOrderto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchDepositsto the latest Korean version and added a link to the global documentation. - Added documentation URL for
fetchDepositto the latest Korean version. - Updated documentation URL for
fetchWithdrawalsto the latest Korean version and added a link to the global documentation. - Added documentation URL for
fetchWithdrawalto the latest Korean version. - Added documentation URL for
fetchOpenOrdersto the latest Korean version. - Added documentation URL for
fetchClosedOrdersto the latest Korean version. - Added documentation URL for
fetchCanceledOrdersto the latest Korean version. - Updated documentation URL for
fetchOrderto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchDepositAddressesto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
fetchDepositAddressto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
createDepositAddressto the latest Korean version and added a link to the global documentation. - Updated documentation URL for
withdrawto the latest Korean version and added a link to the global documentation.
- Updated documentation URL for
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A link updated,
A doc site made anew,
Knowledge flows free.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the documentation site addresses for the Upbit exchange. The changes include updating the KR site address, adding Korean translations, and adding global site documentation addresses. Overall, the changes seem correct and necessary to keep the documentation up-to-date. I am unable to approve this pull request, and users should have others review and approve this code before merging.
Summary of Findings
- Missing documentation: The code changes update the addresses of document sites, but there is no documentation on how to update the addresses if they change again in the future. Please add documentation on how to update the addresses.
Merge Readiness
The pull request updates the documentation site addresses for the Upbit exchange. The changes seem correct and necessary to keep the documentation up-to-date. I recommend merging this pull request after addressing the medium severity issue.
ts/src/upbit.ts
Outdated
| * @method | ||
| * @name upbit#fetchTrades | ||
| * @see https://docs.upbit.com/reference/%EC%B5%9C%EA%B7%BC-%EC%B2%B4%EA%B2%B0-%EB%82%B4%EC%97%AD | ||
| * @see https://docs.upbit.com/kr/reference/최근-채결-내역 |
LambdaBen
force-pushed
the
update/upbit-docs-link
branch
from
e018b71 to
a0a4235
Compare
LambdaBen
force-pushed
the
update/upbit-docs-link
branch
from
a0a4235 to
860d72d
Compare
3 participants
Document 사이트 주소 최신화 건 입니다.
KR 사이트 주소 최신화 및 한글화, global 사이트 문서 주소 추가하였습니다.