Conversation
add memo for CircleComp read circlesAtom inside CircleDrawerPure
artalar
suggested changes
Feb 23, 2024
| return f.toString(); | ||
| } | ||
| }), | ||
| makeSelected: (ctx: Ctx) => { |
There was a problem hiding this comment.
It would be good to wrap all methods to action
Comment on lines
+17
to
+44
| export const CircleDrawerTraditional = reatomComponent(({ ctx }) => { | ||
| const handleAddCircle = useAction(addCircleAction); | ||
| const handleMouseMove = useAction(mouseMoveAction); | ||
| const handleMouseLeave = useAction(mouseLeaveAction); | ||
| const handleContextMenu = useAction(contextMenuAction); | ||
| const handleChangeDiameter = useAction(changeDiameterAction); | ||
| const handleStopChangeDiameter = useAction(stopChangeDiameterAction); | ||
| const handleAdjust = useAction(adjustAction); | ||
| const getClosest = useAction(getClosestAction); | ||
|
|
||
| return ( | ||
| <CircleDrawerPure | ||
| inContextMode={inContextModeAtom} | ||
| onMouseMove={handleMouseMove} | ||
| onMouseLeave={handleMouseLeave} | ||
| onCanvasClick={handleAddCircle} | ||
| onCircleClick={handleContextMenu} | ||
| onAdjustClick={handleAdjust} | ||
| getClosest={getClosest} | ||
| onDiameterChange={handleChangeDiameter} | ||
| onDiameterRelease={handleStopChangeDiameter} | ||
| onUndo={ctx.bind(circlesAtom.undo)} | ||
| onRedo={ctx.bind(circlesAtom.redo)} | ||
| canUndo={ctx.spy(circlesAtom.isUndoAtom)} | ||
| canRedo={ctx.spy(circlesAtom.isRedoAtom)} | ||
| /> | ||
| ); | ||
| }) as React.FC; |
There was a problem hiding this comment.
Suggested change
| export const CircleDrawerTraditional = reatomComponent(({ ctx }) => { | |
| const handleAddCircle = useAction(addCircleAction); | |
| const handleMouseMove = useAction(mouseMoveAction); | |
| const handleMouseLeave = useAction(mouseLeaveAction); | |
| const handleContextMenu = useAction(contextMenuAction); | |
| const handleChangeDiameter = useAction(changeDiameterAction); | |
| const handleStopChangeDiameter = useAction(stopChangeDiameterAction); | |
| const handleAdjust = useAction(adjustAction); | |
| const getClosest = useAction(getClosestAction); | |
| return ( | |
| <CircleDrawerPure | |
| inContextMode={inContextModeAtom} | |
| onMouseMove={handleMouseMove} | |
| onMouseLeave={handleMouseLeave} | |
| onCanvasClick={handleAddCircle} | |
| onCircleClick={handleContextMenu} | |
| onAdjustClick={handleAdjust} | |
| getClosest={getClosest} | |
| onDiameterChange={handleChangeDiameter} | |
| onDiameterRelease={handleStopChangeDiameter} | |
| onUndo={ctx.bind(circlesAtom.undo)} | |
| onRedo={ctx.bind(circlesAtom.redo)} | |
| canUndo={ctx.spy(circlesAtom.isUndoAtom)} | |
| canRedo={ctx.spy(circlesAtom.isRedoAtom)} | |
| /> | |
| ); | |
| }) as React.FC; | |
| export const CircleDrawerTraditional = reatomComponent(({ ctx }) => ( | |
| <CircleDrawerPure | |
| inContextMode={inContextModeAtom} | |
| onMouseMove={ctx.bind(mouseMoveAction)} | |
| onMouseLeave={ctx.bind(mouseLeaveAction)} | |
| onCanvasClick={ctx.bind(addCircleAction)} | |
| onCircleClick={ctx.bind(contextMenuAction)} | |
| onAdjustClick={ctx.bind(adjustAction)} | |
| getClosest={ctx.bind(getClosestAction)} | |
| onDiameterChange={ctx.bind(changeDiameterAction)} | |
| onDiameterRelease={ctx.bind(stopChangeDiameterAction)} | |
| onUndo={ctx.bind(circlesAtom.undo)} | |
| onRedo={ctx.bind(circlesAtom.redo)} | |
| canUndo={ctx.spy(circlesAtom.isUndoAtom)} | |
| canRedo={ctx.spy(circlesAtom.isRedoAtom)} | |
| /> | |
| )); |
| diameter: number, | ||
| ): Circle => { | ||
| const circle: Circle = { | ||
| x: atom(x, "circle-x"), |
There was a problem hiding this comment.
Reatom name convention is separate names by dot (.).
Suggested change
| x: atom(x, "circle-x"), | |
| x: atom(x, "circle.x"), |
| .spy(dbAtom) | ||
| .filter( | ||
| ([_, x]) => | ||
| x.toLowerCase().indexOf(ctx.spy(prefixAtom).toLowerCase()) !== -1, |
There was a problem hiding this comment.
Move the getter outside of the loop (just a good practice)
Comment on lines
+37
to
+46
| const id = ctx.get(selectedAtom); | ||
| const index = ctx.get(dbAtom).findIndex(([i]) => i === id); | ||
| if (index === -1) return; | ||
|
|
||
| handleDelete = () => { | ||
| const id = this.selected.get() | ||
| const index = this.db.findIndex(([i]) => i === id) | ||
| if (index === -1) return | ||
| this.db.splice(index, 1) | ||
| } | ||
| dbAtom(ctx, (prev) => { | ||
| return prev.map((item, i) => { | ||
| if (i !== index) return item; | ||
| return [uuid(), ctx.get(nameAtom)]; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Make the changable value atoms to simplify the change code
ctx.get(dbAtom).find(([i]) => i === id)?.[1](ctx, ctx.get(nameAtom))
Owner
Author
There was a problem hiding this comment.
I tried to do it this way and now there is no re-rendering when handleUpdate is called, because the db array is not changed - the name value in the atom is changed
how can I fix this?
Owner
Author
There was a problem hiding this comment.
here is the corrected version with handleUpdate not working
https://github.com/Laniman/reatom/blob/751-7guis-example/examples/7guis/src/guis/crud.tsx
Owner
Author
There was a problem hiding this comment.
figured it out
I should have used ctx.spy in
<option key={id} value={id}>
{ctx.spy(x)}
</option>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.