Fix panic hook to handle audio backend errors and improve error messaging#184
Merged
LargeModGames merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens runtime error handling around native streaming/audio backends by (1) broadening the panic hook’s detection of recoverable audio backend panics and (2) simplifying the streaming-player disconnect guard logic for readability.
Changes:
- Extend panic-hook detection to treat both PortAudio and Rodio backend panics as “recoverable”, emitting a user-facing message instead of running the normal panic path.
- Refactor
disconnect_streaming_playerto useOption’s?operator when retrieving the current streaming player.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to error handling and code clarity in the audio backend and streaming player logic. The most notable changes are:
Audio Backend Panic Handling:
audio_backend/portaudio.rsandaudio_backend/rodio.rs, improving detection and messaging for recoverable audio backend errors.Streaming Player Logic:
disconnect_streaming_playerto use the?operator for conciseness and readability.