Fix playlist scrolling showing only one track on page boundary#185
Merged
LargeModGames merged 1 commit intomainfrom Mar 22, 2026
Merged
Fix playlist scrolling showing only one track on page boundary#185LargeModGames merged 1 commit intomainfrom
LargeModGames merged 1 commit intomainfrom
Conversation
Replace paged scrolling with smooth scrolling for song tables. The old paged mode would create incomplete visual pages when API page size didn't divide evenly by visible rows, causing the UI to briefly show just 1 song before loading the next page. Smooth scrolling keeps the selected item visible and scrolls one item at a time, providing a better user experience.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TUI table scrolling behavior to avoid “incomplete pages” at API page boundaries (notably in song/track tables), by using a smooth scroll offset calculation so the selected row stays visible without jumping by full “visual pages”.
Changes:
- Removes paged (page-aligned) scrolling behavior for
TableId::Song. - Simplifies
table_scroll_offsetto always use the smooth-scrolling offset calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace paged scrolling with smooth scrolling for song tables. The old paged mode would create incomplete visual pages when API page size didn't divide evenly by visible rows, causing the UI to briefly show just 1 song before loading the next page. Smooth scrolling keeps the selected item visible and scrolls one item at a time, providing a better user experience.