Skip to content

Rename BasicView to LyricsView and add CoverArtView; update key bindings and handlers accordingly#186

Merged
LargeModGames merged 2 commits intomainfrom
feat/cover-art-view-and-lyrics-rename
Mar 22, 2026
Merged

Rename BasicView to LyricsView and add CoverArtView; update key bindings and handlers accordingly#186
LargeModGames merged 2 commits intomainfrom
feat/cover-art-view-and-lyrics-rename

Conversation

@LargeModGames
Copy link
Owner

@LargeModGames LargeModGames commented Mar 22, 2026

This pull request refactors the "Basic View" feature by splitting it into two distinct fullscreen views: "Lyrics View" and "Cover Art View". It updates navigation, settings, keybindings, mouse handling, and rendering logic to support these two views independently. Additionally, it introduces a dedicated protocol state for fullscreen cover art to avoid rendering conflicts, and replaces the old basic_view code with new handlers and UI logic for the updated views.

Key changes include:

Navigation and View Management:

  • Replaces BasicView with LyricsView and CoverArtView in the ActiveBlock and RouteId enums, updating all navigation logic to handle the new views.
    Settings and Keybindings:
  • Renames the "Basic View" keybinding to "Lyrics View" and adds a new keybinding for "Cover Art View" in the user config, settings UI, and serialization logic.

Mouse and Input Handling:

  • Refactors mouse and keyboard event handling to support both fullscreen views, including playbar interactions and navigation. Removes now-obsolete basic_view mouse and handler code, and introduces new handlers for lyrics_view and cover_art_view.

Cover Art Rendering:

  • Adds a dedicated fullscreen_state to the CoverArt struct, ensuring that the playbar and fullscreen cover art can be rendered independently without state conflicts. Updates rendering methods accordingly.

Code Cleanup:

  • Removes the obsolete basic_view handler file and all related code, fully transitioning to the new view structure.

@LargeModGames LargeModGames merged commit bc02341 into main Mar 22, 2026
9 checks passed
@LargeModGames LargeModGames deleted the feat/cover-art-view-and-lyrics-rename branch March 22, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant