Rename BasicView to LyricsView and add CoverArtView; update key bindings and handlers accordingly#186
Merged
LargeModGames merged 2 commits intomainfrom Mar 22, 2026
Conversation
…ngs and handlers accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the "Basic View" feature by splitting it into two distinct fullscreen views: "Lyrics View" and "Cover Art View". It updates navigation, settings, keybindings, mouse handling, and rendering logic to support these two views independently. Additionally, it introduces a dedicated protocol state for fullscreen cover art to avoid rendering conflicts, and replaces the old
basic_viewcode with new handlers and UI logic for the updated views.Key changes include:
Navigation and View Management:
BasicViewwithLyricsViewandCoverArtViewin theActiveBlockandRouteIdenums, updating all navigation logic to handle the new views.Settings and Keybindings:
Mouse and Input Handling:
basic_viewmouse and handler code, and introduces new handlers forlyrics_viewandcover_art_view.Cover Art Rendering:
fullscreen_stateto theCoverArtstruct, ensuring that the playbar and fullscreen cover art can be rendered independently without state conflicts. Updates rendering methods accordingly.Code Cleanup:
basic_viewhandler file and all related code, fully transitioning to the new view structure.