Fix login 405: POST endpoint changed to /account/logon-username#70
Open
rosudrag wants to merge 1 commit intoLavishSoftware:masterfrom
Open
Fix login 405: POST endpoint changed to /account/logon-username#70rosudrag wants to merge 1 commit intoLavishSoftware:masterfrom
rosudrag wants to merge 1 commit intoLavishSoftware:masterfrom
Conversation
CCP changed the EVE SSO login form to POST to /account/logon-username instead of /Account/LogOn, and added a required ClientIdentifier field. Also fix NullReferenceException in GetAccessToken error handling when the Response constructor throws before assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/account/logon-usernameinstead of/Account/LogOn(which now returns 405 Method Not Allowed)ClientIdentifierhidden field to the POST bodyGetAccessTokenerror handler whenresponseis nullDetails
The login page at
/Account/LogOnstill serves the form via GET, but the<form action>now points to/account/logon-usernameand includes a hiddenClientIdentifier=eveLauncherTQfield. The old POST endpoint returns 405, which also triggered a secondary NullReferenceException becauseresponsewas never assigned before the catch block tried to callresponse.ToString().