Fix coinshift proto include path for proto/proto submodule layout#27
Draft
ekulkisnek wants to merge 2 commits into
Draft
Fix coinshift proto include path for proto/proto submodule layout#27ekulkisnek wants to merge 2 commits into
ekulkisnek wants to merge 2 commits into
Conversation
Made-with: Cursor
Made-with: Cursor
Collaborator
|
Thanks for the contribution! There are a few merge conflicts to address — mostly formatting and similar minor issues. Once those are fixed, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/build.rscould not findcusf/common/v1/common.protoaftergit submodule updatebecause theprotorepo keeps files underproto/proto/, notproto/at the submodule root.Changes
lib/build.rs: tryproto/proto, thenproto, then../proto/proto, then../protowhen locating the include root.README.md: document that layout and short maintainer follow-ups (push access; runcargo test --workspaceafter bumping theprotosubmodule).Related PRs
bip300301_wallet, cusf_sidechain, bip300301_enforcer (proto / Jenkins alignment).
Test plan
git submodule update --init --recursivecargo test --workspace