-
Notifications
You must be signed in to change notification settings - Fork 263
feat: use latest initiad & initia.js #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
PR SummaryMedium Risk Overview Extends FA adapter initialization to accept an optional Hyperliquid example/docs are refreshed (rename Written by Cursor Bugbot for commit 2377caf. This will update automatically on new commits. Configure here. |
…ring initialization, so baseXToBytes32 should return without throwing an error in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
|
@beer-1 , can you confirm what the main blocker that this PR is meant to solve? I might ask you to separate out the client only changes, as the contract changes might take longer to approve. |
|
Hey @nazreen, There are three points
We already deployed the contract with this fixes locally, but good to merge this for future usages. |
| childProcess.on('close', (code) => { | ||
| if (code === 0) { | ||
| const accountInfo = JSON.parse(stdout) | ||
| resolve(BigInt(accountInfo.info.sequence) + BigInt(2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beer-1 what's the significance of the value 2 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same reason with this https://github.com/initia-labs/initia/blob/0621b9de571ffde395da7671ad261cf1b4e32557/cmd/move/deploy.go#L110
so sequence number will be increased during this deployment tx.
and in contract we are using sequence+1 as object seed here
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ro-Labs#1929) Signed-off-by: shankar <shankar@layerzerolabs.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: shankar <shankar@layerzerolabs.org>
Summary of Changes