feat(source-generators): add nested object and collection mapping#63
Merged
ncipollina merged 3 commits intomainfrom Jan 21, 2026
Merged
feat(source-generators): add nested object and collection mapping#63ncipollina merged 3 commits intomainfrom
ncipollina merged 3 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abcfc83c2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/CollectionTypeAnalyzer.cs
Show resolved
Hide resolved
src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/NestedObjectTypeAnalyzer.cs
Outdated
Show resolved
Hide resolved
j-d-ha
previously approved these changes
Jan 20, 2026
Collaborator
j-d-ha
left a comment
j-d-ha
left a comment
There was a problem hiding this comment.
👍 Looks good. Left some questions and small suggestions.
...rifyTests.NestedCollection_DictionaryOfNestedObjects_MapperBased#CatalogMapper.g.verified.cs
Show resolved
Hide resolved
src/LayeredCraft.DynamoMapper.Generators/Diagnostics/DiagnosticDescriptors.cs
Show resolved
Hide resolved
Comment on lines
27
to
32
Collaborator
There was a problem hiding this comment.
Can we make these not have default values? I think some of this might be leftover from my work.
Comment on lines
+11
to
+12
| bool IsCustomMethod = false, | ||
| bool IsNestedObjectPlaceholder = false |
src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/NestedObjectTypeAnalyzer.cs
Show resolved
Hide resolved
ncipollina
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
✅ Checklist
🧪 Related Issues or PRs
Closes #48
💬 Notes for Reviewers