fix(source-generators): improve nested property fallback handling for CS8601 warnings#65
Merged
ncipollina merged 3 commits intomainfrom Jan 23, 2026
Merged
Conversation
- Update examples to use consistent formatting - Clean up constructor selector logic - Minor refactoring across generator and test projects - Add tech-debt-analysis documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…warnings - Use `required` keyword to determine when to throw InvalidOperationException - Use empty collection `[]` as fallback for non-nullable, non-required collections - Use `null` as fallback for nullable nested properties - Add helper methods GetNestedObjectFallback and GetNestedCollectionFallback - Add tests for nullable nested objects and collections (mapper-based and inline) This eliminates CS8601 warnings by using appropriate fallbacks: - required + non-nullable: throw InvalidOperationException - nullable: null - non-nullable + non-required collections: empty collection [] - non-nullable + non-required objects: null (design limitation) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7c5ad4f31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/LayeredCraft.DynamoMapper.Generators/PropertyMapping/PropertyMappingCodeRenderer.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
This PR fixes CS8601 "Possible null reference assignment" warnings by implementing smart fallback logic for nested properties based on their characteristics:
required+ non-nullablethrow new System.InvalidOperationException(...)?)null[](empty collection)nullKey Changes
GetNestedObjectFallback()andGetNestedCollectionFallback()helper methods that determine the appropriate fallback based onanalysis.IsRequiredandanalysis.Nullability.IsNullableTypeBefore (caused CS8601 warnings)
After (no warnings)
✅ Checklist
🧪 Related Issues or PRs
N/A
💬 Notes for Reviewers
requiredkeyword and simple non-nullability[]) are used for non-required, non-nullable collections which works in C# 12+nullas fallback - this is a design limitation where the model should either userequiredor be nullable🤖 Generated with Claude Code