Skip to content

fix: pin manylinux2014 image for cp38 wheels #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ramlaoui merged 1 commit into from
May 10, 2026
Merged

fix: pin manylinux2014 image for cp38 wheels #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
# Pinned because manylinux2014_x86_64:latest no longer ships cp38.
MANYLINUX2014_X86_64_IMAGE: quay.io/pypa/manylinux2014_x86_64@sha256:66d0049056d8744efef8f7e973d07acd548a28cda5cf5f6e4040847e34e3bbcc

jobs:
validate-version:
name: Validate tag version
Expand Down Expand Up @@ -142,14 +146,24 @@ jobs:
else
echo "PYBIN=python" >> "$GITHUB_ENV"
fi
- name: Build wheels
- name: Build wheels (Linux)
if: matrix.os == 'ubuntu-latest'
uses: PyO3/maturin-action@v1
with:
command: build
args: --release --out dist --interpreter ${{ env.PYBIN }}
working-directory: atompack-py
target: ${{ env.TARGET }}
manylinux: 2_17
container: ${{ env.MANYLINUX2014_X86_64_IMAGE }}
- name: Build wheels (non-Linux)
if: matrix.os != 'ubuntu-latest'
uses: PyO3/maturin-action@v1
with:
command: build
args: --release --out dist --interpreter ${{ env.PYBIN }}
working-directory: atompack-py
target: ${{ env.TARGET }}
manylinux: auto
- uses: actions/upload-artifact@v4
with:
name: wheels-${{ env.TARGET }}-py${{ matrix.python-version }}
Expand Down
30 changes: 27 additions & 3 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
# Pinned because manylinux2014_x86_64:latest no longer ships cp38.
MANYLINUX2014_X86_64_IMAGE: quay.io/pypa/manylinux2014_x86_64@sha256:66d0049056d8744efef8f7e973d07acd548a28cda5cf5f6e4040847e34e3bbcc

jobs:
build-wheels:
name: Build wheels (${{ matrix.os }}, py${{ matrix.python-version }})
Expand Down Expand Up @@ -54,14 +58,34 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Build wheels
- name: Set Python interpreter
shell: bash
run: |
if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
PYTAG="${{ matrix.python-version }}"
PYTAG="${PYTAG/.}"
echo "PYBIN=/opt/python/cp${PYTAG}-cp${PYTAG}/bin/python" >> "$GITHUB_ENV"
else
echo "PYBIN=python" >> "$GITHUB_ENV"
fi
- name: Build wheels (Linux)
if: matrix.os == 'ubuntu-latest'
uses: PyO3/maturin-action@v1
with:
command: build
args: --release --out dist --interpreter ${{ env.PYBIN }}
working-directory: atompack-py
target: ${{ env.TARGET }}
manylinux: 2_17
container: ${{ env.MANYLINUX2014_X86_64_IMAGE }}
- name: Build wheels (non-Linux)
if: matrix.os != 'ubuntu-latest'
uses: PyO3/maturin-action@v1
with:
command: build
args: --release --out dist --interpreter python
args: --release --out dist --interpreter ${{ env.PYBIN }}
working-directory: atompack-py
target: ${{ env.TARGET }}
manylinux: auto
- uses: actions/upload-artifact@v4
with:
name: wheels-${{ env.TARGET }}-py${{ matrix.python-version }}
Expand Down
Loading