Add support to run benchmark script to load from aselmdb file#72
Open
Add support to run benchmark script to load from aselmdb file#72
Conversation
sid-betalol
requested changes
Oct 6, 2025
Collaborator
There was a problem hiding this comment.
Hi @jmusiel! Thanks for adding this feature. Right now, we’re able to choose the source of input files using the command line.
See lines 828-834 in run_benchmarks.py:
parser.add_argument(
"--cifs",
help="Path to text file containing CIF file paths OR directory containing CIF files",
)
parser.add_argument(
"--csv", help="Path to CSV file containing structures in LeMatStructs column"
)And we raise an error if the input is not provided in the desired file formats (see lines 867-870):
if not args.cifs and not args.csv:
parser.error("Either --cifs or --csv must be provided")
if args.cifs and args.csv:
parser.error("Only one of --cifs or --csv can be provided")Would it be possible to similarly extend the benchmark script to support loading from an .aselmdb file as an additional option for backwards compatibility, instead of overwriting the existing options?
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the run_benchmarks script to load from aselmdb files
Tested this change and it works, however this change overwrites the old functionality of loading from cifs.
If you want me to add a new script, or modify this to be backwards compatible and use either/or loading, let me know how you would like this handled.