Open
Conversation
davidan1981
commented
Mar 9, 2016
davidan1981
commented
- I know we need to further clarify what a context is. But, at least, we can remove some ambiguity around resource listing when there is no root specified.
- Added a sentence about generating UUID for legacy data partially using legacy IDs.
- Added a sentence about multipart requests. Yes, multipart requests are legit API requests.
- Added myself to the list of contributors.
- Other minor edits and additions.
| endpoint may list all of the current context's `sprocket`s, or similar, but in | ||
| general should not accept creation requests. In concrete examples: | ||
| - `POST /sprockets` is invalid. | ||
| - `POST /sprockets` is invalid unless `widget` is specified in the payload. |
There was a problem hiding this comment.
Was initially hesitant to accept this but I think it's alright. If this is done in practice maybe we can settle on a request format that guides the implementation more.
|
I only have one showstopper; appreciate all of the improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.