Skip to content

feat(library): filter for enabled only#157

Merged
Crauzer merged 1 commit into
LeagueToolkit:mainfrom
danielriosr:feat-view-enabled
May 8, 2026
Merged

feat(library): filter for enabled only#157
Crauzer merged 1 commit into
LeagueToolkit:mainfrom
danielriosr:feat-view-enabled

Conversation

@danielriosr
Copy link
Copy Markdown
Contributor

Feature: Creates a button in the top bar to allow users to quick filter "only enabled"

Preview without button disabled (not pressed):
image

Preview with button enabled:
image

@Crauzer
Copy link
Copy Markdown
Member

Crauzer commented May 5, 2026

It would be nice if we moved this function as a button in the dedicated "Filters" popup that we already have - so we don't clutter the toolbar,

@Crauzer Crauzer added area: frontend React/TypeScript UI type: ux User experience improvements priority: low Nice to have labels May 5, 2026
@Crauzer Crauzer moved this from Todo to In Progress in LTK Manager May 5, 2026
@danielriosr
Copy link
Copy Markdown
Contributor Author

Moved feature to Filters as suggested:

image

@Crauzer
Copy link
Copy Markdown
Member

Crauzer commented May 5, 2026

Can you please also squash the commits and format it like feat(library): filter for enabled only or such. This way it shows properly in the changelog when we merge it. Thx :)

@danielriosr danielriosr force-pushed the feat-view-enabled branch from 1f9148a to 212c381 Compare May 6, 2026 00:07
@danielriosr danielriosr changed the title feat(library): Show only enabled quick button feat(library): filter for enabled only May 6, 2026
@danielriosr
Copy link
Copy Markdown
Contributor Author

Can you please also squash the commits and format it like feat(library): filter for enabled only or such. This way it shows properly in the changelog when we merge it. Thx :)

Done! Let me know if its okay now :)

Crauzer
Crauzer previously approved these changes May 6, 2026
@Crauzer
Copy link
Copy Markdown
Member

Crauzer commented May 6, 2026

Need to make tsc happy I guess, just amend the commit onto this one

@danielriosr
Copy link
Copy Markdown
Contributor Author

Oh most of them are because there were some leftover code related to the toolbar, which now we are not using, as we moved it inside the filters popup. Fixing Asap then squashing again.

@danielriosr danielriosr force-pushed the feat-view-enabled branch from d8bc7db to 5c762c0 Compare May 6, 2026 18:19
@danielriosr
Copy link
Copy Markdown
Contributor Author

@Crauzer OK I think now it should be clean and ready to go. Please let me know.

@Crauzer Crauzer merged commit 5dc34a3 into LeagueToolkit:main May 8, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LTK Manager May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: frontend React/TypeScript UI priority: low Nice to have type: ux User experience improvements

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants