fix(library): allow folder drops when non-priority sort is active#207
Open
helseaCat wants to merge 1 commit into
Open
fix(library): allow folder drops when non-priority sort is active#207helseaCat wants to merge 1 commit into
helseaCat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #181
Problem
Selecting any sort other than "Priority" disabled all drag-and-drop, including dragging mods into folders. The single
dndDisabledflag gated both reordering and folder drops.Steps to reproduce
Fix
Split
dndDisabledintodndDisabled(search/patcher/filters) andreorderDisabled(non-priority sort). DnD stays active for folder drops; only reordering is suppressed.Also rewrote collision detection to use
pointerWithinfor folder targets in all sort modes — folders only highlight when the pointer is directly over them, fixing a pre-existing issue where nearby folders would falsely activate.Verification
pnpm checkpasses (typecheck + lint + format + 268 tests)