complete asl course page with tree#54
Open
Sreshty-Beshty wants to merge 9 commits intoLearnPRG-py:mainfrom
Open
complete asl course page with tree#54Sreshty-Beshty wants to merge 9 commits intoLearnPRG-py:mainfrom
Sreshty-Beshty wants to merge 9 commits intoLearnPRG-py:mainfrom
Conversation
minor things such as navbar and the actual course videos are needed, but this provides a solid foundation to be able to develop our course
✅ Deploy Preview for soft-babka-dec3e0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
Gave it a functional look through - couple changes needed |
LearnPRG-py
requested changes
Apr 5, 2026
Owner
LearnPRG-py
left a comment
LearnPRG-py
left a comment
There was a problem hiding this comment.
I'd say a lot of work is still left, formatting I can take up in a seperate PR.
| <link rel="stylesheet" href="../../../Navbar/styles.css"> | ||
| </head> | ||
| <body> | ||
| <!-- <div id="navbarcontainer"></div> --> |
Owner
There was a problem hiding this comment.
Add navbar back in but make it only appear with either a button press or when the Y of the mouse is < 10% from the top.
| <script type="module" src="../../../Navbar/script.js"></script> | ||
| <script src="script.js"></script> | ||
| </body> | ||
| </html> No newline at end of file |
Owner
There was a problem hiding this comment.
You know what I am going to say.
| document.getElementById('loading-overlay').classList.add('hidden'); | ||
| } | ||
|
|
||
| init(); No newline at end of file |
| }); | ||
| } | ||
|
|
||
| const arrowSvg = `<svg width="14" height="14" viewBox="0 0 14 14" fill="none"><path d="M5 2l4.5 5L5 12" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/></svg>`; |
Owner
There was a problem hiding this comment.
split across multiple lines maybe for readability
| animation-duration:${dur}s;animation-delay:${-Math.random()*dur}s;filter:blur(${size>2?0.5:0}px);`; | ||
| document.body.appendChild(el); | ||
| } | ||
| })(); No newline at end of file |
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| text-align: center; | ||
| } No newline at end of file |
Owner
There was a problem hiding this comment.
To be implimented: maybe make it a seperate PR if you want to stop blocking it, or you could have it in the same PR either works
Owner
There was a problem hiding this comment.
Don't use spaces in folder names plz
maybe ASL_course, or maybe just ASL as Courses/ASL course seems redundant
Add missing newline at the end of the HTML file.
Add missing newline at the end of the HTML file.
LearnPRG-py
requested changes
Apr 27, 2026
| </filter> | ||
| </defs> | ||
| <foreignObject width="240" height="240" clip-path="url(#cl${id})"> | ||
| <g clip-path="url(#cl${id})"><foreignObject width="240" height="240"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor things such as navbar and the actual course videos are needed, but this provides a solid foundation to be able to develop our course