Skip to content

πŸ“ (doc) [NO-ISSUE]: Added legal notice in doc#1412

Open
cfranceschi-ledger wants to merge 2 commits intodevelopfrom
doc/no-issue-notice
Open

πŸ“ (doc) [NO-ISSUE]: Added legal notice in doc#1412
cfranceschi-ledger wants to merge 2 commits intodevelopfrom
doc/no-issue-notice

Conversation

@cfranceschi-ledger
Copy link
Copy Markdown
Collaborator

πŸ“ Description

Added the legal notice in the documentation

❓ Context

[NO-ISSUE]

βœ… Checklist

Not applicable, only documentation was modified.


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@cfranceschi-ledger cfranceschi-ledger requested a review from a team as a code owner April 9, 2026 14:55
Copilot AI review requested due to automatic review settings April 9, 2026 14:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a β€œLegal notice” section to the Getting Started documentation to clarify licensing and prohibited access to Ledger SAS backend services.

Changes:

  • Appends a new β€œLegal notice” section to the docs landing page.
  • Describes permitted DMK usage and restrictions around Ledger SAS backend/tokens/APIs.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


The Device Management Kit (DMK) is made available under an open source license and is free to use for development, testing, and integration purposes.

Please note that access to the DMK does not grant you any rights to access Ledger SAS backend services, nor any rights to use tokens, APIs, or infrastructure beyond what is explicitly allowed under the open source license. Access to Ledger SAS backend is strictly prohibited unless explicitly authorized by Ledger SAS. cfranceschi-ledger marked this conversation as resolved.
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence ends with what looks like a GitHub UI artifact ("cfranceschi-ledger marked this conversation as resolved.") which will be rendered in the published docs. Please remove this stray text.

Suggested change
Please note that access to the DMK does not grant you any rights to access Ledger SAS backend services, nor any rights to use tokens, APIs, or infrastructure beyond what is explicitly allowed under the open source license. Access to Ledger SAS backend is strictly prohibited unless explicitly authorized by Ledger SAS. cfranceschi-ledger marked this conversation as resolved.
Please note that access to the DMK does not grant you any rights to access Ledger SAS backend services, nor any rights to use tokens, APIs, or infrastructure beyond what is explicitly allowed under the open source license. Access to Ledger SAS backend is strictly prohibited unless explicitly authorized by Ledger SAS.

Copilot uses AI. Check for mistakes.

## Legal notice

The Device Management Kit (DMK) is made available under an open source license and is free to use for development, testing, and integration purposes.
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"made available under an open source license" is ambiguous for a legal notice. Consider explicitly naming the license used by this repo (or linking to the LICENSE/Licenses page) so readers know what terms apply.

Suggested change
The Device Management Kit (DMK) is made available under an open source license and is free to use for development, testing, and integration purposes.
The Device Management Kit (DMK) is made available under the license terms set out in this repository's LICENSE file and is free to use for development, testing, and integration purposes.

Copilot uses AI. Check for mistakes.
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
device-sdk-ts-sample Ready Ready Preview, Comment Apr 9, 2026 3:13pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
doc-device-management-kit Ignored Ignored Apr 9, 2026 3:13pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Danger Check Results

Messages

⚠️

No changeset file found. Please make sure this is intended or add a changeset file.

βœ…

Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against 7712fce

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants