Skip to content

✨ (context-module) [LIVE-26528]: Add account ownership context loader for concordium address verification#1416

Merged
lysyi3m merged 1 commit intodevelopfrom
feat/live-26528-concordium-lw-implement-context-module-for-account-ownership
Apr 16, 2026
Merged

✨ (context-module) [LIVE-26528]: Add account ownership context loader for concordium address verification#1416
lysyi3m merged 1 commit intodevelopfrom
feat/live-26528-concordium-lw-implement-context-module-for-account-ownership

Conversation

@lysyi3m
Copy link
Copy Markdown
Contributor

@lysyi3m lysyi3m commented Apr 13, 2026

📝 Description

Implements the context module layer for the Concordium verify-address flow (ADR 001). Adds a new ACCOUNT_OWNERSHIP context type and a loader that queries the trusted metadata service (GET /v2/concordium/owner/{pubkey}/{address}) for signed account ownership descriptors, along with PKI certificate loading for device-side verification. This follows the same architecture as the existing Safe module and lays the groundwork for the signer-concordium's verifyAddress implementation in a follow-up PR.

❓ Context

  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes: The ACCOUNT_OWNERSHIP enum addition required mechanical updates to all exhaustive ClearSignContextType switches in signer-eth (ProvideContextTask, BuildBaseContexts, BuildSubcontextsTask, ProvideEIP712ContextTask) — no behavioral change, just adding pass-through/unsupported cases.

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@lysyi3m lysyi3m requested a review from a team as a code owner April 13, 2026 08:40
Copilot AI review requested due to automatic review settings April 13, 2026 08:40
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
device-sdk-ts-sample Ready Ready Preview, Comment Apr 14, 2026 0:14am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
doc-device-management-kit Ignored Ignored Apr 14, 2026 0:14am

Request Review

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

Danger Check Results

Messages

Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 106a40f

@lysyi3m lysyi3m changed the title ✨ (context-module) [/LIVE-26528]: add account ownership context loader for concordium address verification ✨ (context-module) [/LIVE-26528]: Add account ownership context loader for concordium address verification Apr 13, 2026
@lysyi3m lysyi3m changed the title ✨ (context-module) [/LIVE-26528]: Add account ownership context loader for concordium address verification ✨ (context-module) [LIVE-26528]: Add account ownership context loader for concordium address verification Apr 13, 2026
@lysyi3m lysyi3m force-pushed the feat/live-26528-concordium-lw-implement-context-module-for-account-ownership branch from 0965416 to 1cda93d Compare April 13, 2026 08:54
@lysyi3m lysyi3m force-pushed the feat/live-26528-concordium-lw-implement-context-module-for-account-ownership branch from 1cda93d to 254d8fa Compare April 13, 2026 14:16
@lysyi3m lysyi3m requested a review from Copilot April 13, 2026 14:18

This comment was marked as resolved.

@lysyi3m lysyi3m force-pushed the feat/live-26528-concordium-lw-implement-context-module-for-account-ownership branch from 254d8fa to 106a40f Compare April 14, 2026 12:11
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@lysyi3m lysyi3m added this pull request to the merge queue Apr 16, 2026
Merged via the queue into develop with commit 7b5d16c Apr 16, 2026
55 of 59 checks passed
@lysyi3m lysyi3m deleted the feat/live-26528-concordium-lw-implement-context-module-for-account-ownership branch April 16, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants