✨ (signer-concordium) [LIVE-26529]: Add verifyAddress with trusted backend support by lysyi3m · Pull Request #1425 · LedgerHQ/device-sdk-ts

lysyi3m · 2026-04-13T17:49:25Z

📝 Description

Implements the verifyAddress method for @ledgerhq/device-signer-kit-concordium following the "trusted backend" pattern defined in ADR 001.
The full device flow orchestrates six APDU steps:

get public key,
get challenge,
fetch signed account ownership descriptor from the trusted metadata service (via context-module),
load PKI certificate,
set trusted name descriptor,
and verify address — where the device validates the certificate chain, matches the derived key against the descriptor, and displays the address for user approval.

The SignerConcordiumBuilder gains a withContextModule() method to inject the context module dependency.

❓ Context

JIRA or GitHub link: LIVE-26529

Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

Covered by automatic tests
Changeset is provided
Documentation is up-to-date
Impact of the changes: new functionality added

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.

vercel · 2026-04-13T17:49:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
device-sdk-ts-sample	Ready	Preview, Comment	Apr 17, 2026 1:02pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
doc-device-management-kit	Ignored		Apr 17, 2026 1:02pm

github-actions · 2026-04-13T17:59:34Z

Danger Check Results

Messages

✅	Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against eab6d58

Copilot

Pull request overview

Copilot reviewed 27 out of 28 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fAnselmi-Ledger · 2026-04-17T12:18:35Z

    return new DefaultSignerConcordium({
      dmk: this._dmk,
      sessionId: this._sessionId,
+      contextModule: this._customContextModule,


[SHOULD] Currently, calling verifyAddress without withContextModule() throws, We should provide a default ContextModule to have a safer API and more consistent with the other signers WDYT?

@fAnselmi-Ledger nice catch.

done ✅

fAnselmi-Ledger · 2026-04-17T12:22:25Z

+
+const DERIVATION_PATH = "44'/919'/0'/0'/0'";
+const ADDRESS = "3kFkntk2H5FGMzeR3GjQKPhdZK9LShKdPHsj2fiGKCdmDXj2WB";
+const NETWORK = "mainnet" as const;


[COULD] This could be an ENUM!

…ckend support

sonarqubecloud · 2026-04-17T13:03:09Z

Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

lysyi3m requested a review from a team as a code owner April 13, 2026 17:49

Copilot AI review requested due to automatic review settings April 13, 2026 17:49

github-actions bot assigned lysyi3m Apr 13, 2026

Copilot started reviewing on behalf of lysyi3m April 13, 2026 17:49 View session

This comment was marked as resolved.

Sign in to view

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from dd64798 to bc0c7fa Compare April 13, 2026 18:13

lysyi3m requested a review from Copilot April 13, 2026 18:14

vercel bot deployed to Preview – device-sdk-ts-sample April 13, 2026 18:14 View deployment

Copilot started reviewing on behalf of lysyi3m April 13, 2026 18:14 View session

This comment was marked as resolved.

Sign in to view

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from bc0c7fa to 5b29cb9 Compare April 13, 2026 18:26

lysyi3m requested a review from Copilot April 13, 2026 18:27

vercel bot deployed to Preview – device-sdk-ts-sample April 13, 2026 18:27 View deployment

Copilot started reviewing on behalf of lysyi3m April 13, 2026 18:28 View session

This comment was marked as resolved.

Sign in to view

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 5b29cb9 to 16cb97f Compare April 13, 2026 18:36

lysyi3m requested a review from Copilot April 13, 2026 18:36

Copilot started reviewing on behalf of lysyi3m April 13, 2026 18:37 View session

vercel bot deployed to Preview – device-sdk-ts-sample April 13, 2026 18:37 View deployment

This comment was marked as resolved.

Sign in to view

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 16cb97f to 0e41433 Compare April 13, 2026 18:47

lysyi3m requested a review from Copilot April 13, 2026 18:47

Copilot started reviewing on behalf of lysyi3m April 13, 2026 18:48 View session

vercel bot deployed to Preview – device-sdk-ts-sample April 13, 2026 18:48 View deployment

This comment was marked as resolved.

Sign in to view

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 0e41433 to 8be2fba Compare April 13, 2026 19:21

lysyi3m requested a review from Copilot April 13, 2026 19:21

Copilot started reviewing on behalf of lysyi3m April 13, 2026 19:22 View session

lysyi3m requested a review from Copilot April 13, 2026 19:43

Copilot started reviewing on behalf of lysyi3m April 13, 2026 19:43 View session

This comment was marked as resolved.

Sign in to view

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 16ba8a5 to 817ace2 Compare April 13, 2026 20:12

lysyi3m requested a review from Copilot April 13, 2026 20:12

Copilot started reviewing on behalf of lysyi3m April 13, 2026 20:12 View session

vercel bot deployed to Preview – device-sdk-ts-sample April 13, 2026 20:13 View deployment

Copilot AI reviewed Apr 13, 2026

View reviewed changes

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 817ace2 to 2ec9fcd Compare April 14, 2026 06:52

vercel bot deployed to Preview – device-sdk-ts-sample April 14, 2026 06:52 View deployment

lysyi3m force-pushed the feat/live-26528-concordium-lw-implement-context-module-for-account-ownership branch from 254d8fa to 106a40f Compare April 14, 2026 12:11

Base automatically changed from feat/live-26528-concordium-lw-implement-context-module-for-account-ownership to develop April 16, 2026 09:25

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 2ec9fcd to 20a481d Compare April 16, 2026 12:24

vercel bot deployed to Preview – device-sdk-ts-sample April 16, 2026 12:25 View deployment

ishaba approved these changes Apr 16, 2026

View reviewed changes

OlivierFreyssinet approved these changes Apr 17, 2026

View reviewed changes

fAnselmi-Ledger reviewed Apr 17, 2026

View reviewed changes

✨ (signer-concordium) [LIVE-26529]: Add verifyAddress with trusted ba…

eab6d58

…ckend support

lysyi3m force-pushed the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch from 20a481d to eab6d58 Compare April 17, 2026 13:01

lysyi3m requested a review from Copilot April 17, 2026 13:01

Copilot started reviewing on behalf of lysyi3m April 17, 2026 13:02 View session

vercel bot deployed to Preview – device-sdk-ts-sample April 17, 2026 13:02 View deployment

This comment was marked as resolved.

Sign in to view

fAnselmi-Ledger approved these changes Apr 17, 2026

View reviewed changes

lysyi3m added this pull request to the merge queue Apr 17, 2026

Merged via the queue into develop with commit 14e4b61 Apr 17, 2026
28 of 29 checks passed

lysyi3m deleted the feat/live-26529-concordium-lw-implement-verify-address-in-the-new-signer-package branch April 17, 2026 14:02

Conversation

lysyi3m commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

❓ Context

✅ Checklist

🧐 Checklist for the PR Reviewers

Uh oh!

vercel bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Danger Check Results

Messages

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

fAnselmi-Ledger Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

lysyi3m Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

fAnselmi-Ledger Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 17, 2026

Quality Gate failed

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lysyi3m commented Apr 13, 2026 •

edited

Loading

vercel bot commented Apr 13, 2026 •

edited

Loading

github-actions bot commented Apr 13, 2026 •

edited

Loading