Skip to content

Upgrade react-native-fast-crypto to our fork that supports Android 16KB#11959

Merged
gre-ledger merged 1 commit intodevelopfrom
support/live-21188
Oct 31, 2025
Merged

Upgrade react-native-fast-crypto to our fork that supports Android 16KB#11959
gre-ledger merged 1 commit intodevelopfrom
support/live-21188

Conversation

@gre-ledger
Copy link
Copy Markdown
Contributor

@gre-ledger gre-ledger commented Sep 23, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Bitcoin support on Ledger Live Mobile
    • iOS and Android

📝 Description

To make react-native-fast-crypto supports Android 16KB, we had to fork the library and upgrade all its stack.
The fork is currently sent as a PR back into the lib: EdgeApp/react-native-fast-crypto#57
Ideally we don't merge this current PR before the library owner issue a new version, but we will if it doesn't happen before our deadlines.

Meanwhile, this make one less library to port to Android 16KB support 🚀 and one more remaining

Screenshot 2025-09-23 at 10 35 32

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre-ledger gre-ledger requested a review from a team September 23, 2025 08:46
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Oct 31, 2025 9:06am
native-ui-storybook Ignored Ignored Preview Oct 31, 2025 9:06am
react-ui-storybook Ignored Ignored Preview Oct 31, 2025 9:06am
web-tools Ignored Ignored Preview Oct 31, 2025 9:06am

@live-github-bot live-github-bot Bot added the mobile Has changes in LLM label Sep 23, 2025
@sonarqubecloud
Copy link
Copy Markdown

@gre-ledger gre-ledger added the HODL Do not merge label Sep 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions Bot added the Stale label Oct 9, 2025
@github-actions github-actions Bot closed this Oct 17, 2025
@gre-ledger gre-ledger reopened this Oct 30, 2025
@gre-ledger gre-ledger marked this pull request as draft October 30, 2025 09:58
@gre-ledger gre-ledger marked this pull request as ready for review October 30, 2025 13:11
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop this I think

@gre-ledger gre-ledger removed the HODL Do not merge label Oct 31, 2025
@sonarqubecloud
Copy link
Copy Markdown

@gre-ledger gre-ledger merged commit 3dd087e into develop Oct 31, 2025
67 of 68 checks passed
@gre-ledger gre-ledger deleted the support/live-21188 branch October 31, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile Has changes in LLM Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants