fix: correctly report Windows 11 in device model header#3
Open
JerryAZR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows 11,
getDeviceModel()currently reports the device asWindows 10.0.26200 x86_64(or similar) becauseNode.js's
os.release()returns the kernel version string (e.g."10.0.26200"), which uses the Windows 10 majorversion even on Windows 11.
Expected behavior
The upstream
kimi-cli(Python) detects Windows 11 by checkingsys.getwindowsversion().buildand reportsWindows 11 x86_64when the build is ≥ 22000. This provider should match that behavior.Fix
os.release()on Windows."10"and the build is ≥ 22000, report"11"instead.Windows 10,Windows 11) to match the upstreamkimi-clilogic.Reference
Upstream Python implementation:
kimi-cli/auth/oauth.py—def _device_model() -> str:Summary by cubic
Fix Windows device model header to report Windows 11 by parsing the build from
os.release()and mapping build ≥22000 to version 11. Only the major Windows version is sent (e.g., "Windows 10", "Windows 11"), matchingkimi-cli.Written for commit 4a5a6a7. Summary will update on new commits.