Use output ItemStack in Mincer - #59
Open
cbrintnall wants to merge 1 commit into
Open
Conversation
Author
|
I'm also noticing that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered this issue when trying to figure out why data components weren't getting copied during the recipe assembly phase. The issue is that the old approach loses any data components on output. The recipe assembly process provides copies of
ItemStackso theres no need to copy it here (unless another mod decides to violate this).You can see this fixes the issue here:

The

Max Health: +2comes from my mod forwarding the data component from beef -> minced beef.I'm not sure if there were other reasons for manually copying the ItemStack here so let me know cause the alternative is copying over all the data components, but afaik that is wasted work.