Skip to content

Use output ItemStack in Mincer - #59

Open
cbrintnall wants to merge 1 commit into
Let-s-Do-Collection:1.21.1from
cbrintnall:1.21.1
Open

Use output ItemStack in Mincer#59
cbrintnall wants to merge 1 commit into
Let-s-Do-Collection:1.21.1from
cbrintnall:1.21.1

Conversation

@cbrintnall

Copy link
Copy Markdown

I discovered this issue when trying to figure out why data components weren't getting copied during the recipe assembly phase. The issue is that the old approach loses any data components on output. The recipe assembly process provides copies of ItemStack so theres no need to copy it here (unless another mod decides to violate this).

You can see this fixes the issue here:
image

The Max Health: +2 comes from my mod forwarding the data component from beef -> minced beef.
image

I'm not sure if there were other reasons for manually copying the ItemStack here so let me know cause the alternative is copying over all the data components, but afaik that is wasted work.

@cbrintnall

cbrintnall commented Aug 1, 2026

Copy link
Copy Markdown
Author

I'm also noticing that assembly returns empty items. My understanding is that assembly is what should be used for input items -> output and getResultItem() is for informational purposes without context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant