Skip to content

chore(scripts): improve shell compatibility in installer#15

Merged
Lftobs merged 2 commits into
devfrom
fix/hot-fix
Jun 20, 2026
Merged

chore(scripts): improve shell compatibility in installer#15
Lftobs merged 2 commits into
devfrom
fix/hot-fix

Conversation

@Lftobs

@Lftobs Lftobs commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Description

fix install script

Fixes #(issue)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes)
  • CI / Build / Tooling
  • Other (please describe):

How Has This Been Tested?

  • Existing tests pass (bun test in apps/api/)
  • New tests added (if applicable)
  • Manual testing performed (describe steps)

Checklist

  • My code follows the project's code style (no comments, named exports, functional components, etc.)
  • I have read the contributing guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation (if applicable)
  • My changes generate no new warnings or lint errors
  • I have run bun test in apps/api/ and all tests pass
  • I have synced the VERSION file if needed (bun run sync-versions)

Summary by CodeRabbit

  • Chores
    • Standardized installation script output handling for improved consistency.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c9e0c674-6985-4445-a2f7-07c19bda67b5

📥 Commits

Reviewing files that changed from the base of the PR and between 78cded2 and 7276cee.

📒 Files selected for processing (1)
  • scripts/install.sh

📝 Walkthrough

Walkthrough

In scripts/install.sh, three output-suppression redirects within the check_prerequisites function are changed from &>/dev/null to >/dev/null 2>&1. The Docker and Docker Compose detection branching logic, messages, and COMPOSE_CMD assignment remain unchanged.

Changes

Output Redirect Standardization

Layer / File(s) Summary
Redirect syntax in check_prerequisites
scripts/install.sh
Docker and Docker Compose version checks replace &>/dev/null with >/dev/null 2>&1; all branching logic, messages, and COMPOSE_CMD selection are unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through the shell script den,
Swapping &> for >/dev/null 2>&1 again,
POSIX whispers, "Now we're aligned!"
Stderr and stdout both redirected, refined,
The burrow is tidy — hooray! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: standardizing shell redirects in the installer script to improve compatibility across different shell environments.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hot-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lftobs Lftobs merged commit 5c1f61b into dev Jun 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant