✨ feat: add configurable avatar badge#5
Conversation
|
Thanks for the PR! I'm a bit concerned about potential abuse — anyone could sign a script with a misleading name, which might cause copyright confusion. This needs some discussion and careful thought before merging. |
|
I understand the concern about people using misleading names or avatars. But I don't think disabling customization really prevents that. Anyone who wants to can still edit screenshots in photoshop or ai,or fork the project. For normal users, having a custom name and avatar is just a nice way to give proper credit to the creator of a script. And for sharing their scripts. Many users spend dozens of hours creating and balancing custom scripts. Allowing them to put their own name and avatar is great. You can also just download the official english or german scripts other then try to rebuild the original. I find this function good, but if you are really concerned maybe a better solution you can do, keep customization, but add something like an "Unofficial Community Script" note. Which should be integrated nicely. This are my thoughts about it |
|
Hey, thanks again for the PR and the thoughtful discussion! After reviewing more carefully, I realized there's an issue: the tool author attribution and the script author attribution are two different things, and this PR currently merges them into a single slot. The original designer badge (onion avatar + "Design: Onion") at the top-left is the tool author credit — it represents who built and maintains the BOTC Script Tool itself. That needs to stay fixed and non-overridable. What you're proposing — a customizable avatar and name for the person who designed the script — is a great idea, but it should be a separate slot. Think of it like:
I've already restored the original tool author badge on the Would you be open to adjusting the PR so that the configurable designer badge is an additional slot for the script author, placed somewhere else on the page (e.g., near the script title area), rather than replacing the existing tool author badge? Happy to discuss placement ideas! |
|
Thanks for explaining your reasoning. I understand why you want to keep tool attribution, but I personally feel the current badge looks more like a watermark than a credit and distracts from the script itself. The script author does not need the same avatar badge, under the title is already that opportunity. I also think an open-source project is built by many contributors over time, so a permanent personal badge doesn't fully reflect that. If you want to keep attribution on the script, maybe just consider redesigning it so it integrates more naturally into the layout and feels less intrusive. Of course, it's your project, so I respect whatever you decide. I just wanted to explain my point of view. |
|
Thanks again for sharing your thoughts — I've read them carefully.
|
New Customized Avatar Badge for own script design.
Please use this order:
yes, click Compare & pull request, but open them in this order:
feat/german-support -> LiWeny16/main
feat/editable-night-order -> LiWeny16/main
feat/avatar-badge-settings -> LiWeny16/main
After PR #1 is merged: feat/german-character-translations -> LiWeny16/main
For feat/german-character-translations, wait until feat/german-support is merged first, because it depends on the German language type existing