Closed
Conversation
Release/v 1.4.3
…ernizing type hints
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1522 +/- ##
===========================================
- Coverage 78.27% 76.93% -1.35%
===========================================
Files 76 77 +1
Lines 7674 7816 +142
Branches 1146 1160 +14
===========================================
+ Hits 6007 6013 +6
- Misses 1469 1602 +133
- Partials 198 201 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmlarson1
reviewed
Feb 21, 2025
| pre-commit = ">=4.0.1,<5" | ||
| nlopt = ">=2.8.0,<3" | ||
| scipy = ">=1.9.1,<2" | ||
| ipdb = ">=0.13.13,<0.14" |
Member
Author
There was a problem hiding this comment.
Nope, I just added it to the dev virtual environment.
jmlarson1
approved these changes
Feb 21, 2025
shuds13
reviewed
Mar 18, 2025
| self.gen_ngpus = libE_info.get("num_gpus") | ||
|
|
||
| def set_resources(self, resources: Resources) -> None: | ||
| def set_resources(self, resources) -> None: |
Member
Author
There was a problem hiding this comment.
We don't necessarily need to import the class just for typehint purposes
shuds13
reviewed
Mar 18, 2025
| data: Data, | ||
| search_space: Optional[SearchSpace] = None, | ||
| trial_index: Optional[int] = None, | ||
| search_space: Optional[SearchSpace] = None, # noqa: MDA501 |
shuds13
reviewed
Mar 18, 2025
|
|
||
| @abstractmethod | ||
| def live_update(self, hist: npt.NDArray) -> None: | ||
| def live_update(self, hist: object) -> None: |
shuds13
reviewed
Mar 18, 2025
| return Executor | ||
|
|
||
| def _result(self, calc_in: npt.NDArray, persis_info: dict, libE_info: dict) -> (npt.NDArray, dict, Optional[int]): | ||
| def _result(self, calc_in: npt.NDArray, persis_info: dict, libE_info: dict) -> (npt.NDArray, dict, int | None): |
Member
There was a problem hiding this comment.
npt.NDArray still here but not above?
Member
|
There are still some places public facing functions without type hints (like tools.py). is there the some method to what has hints or not. |
Member
Author
|
Merging develop into this. Warning ahead of time that the upcoming commit will contain fixes to address: |
… presumably-extra redefinitions of imports or objects in persistent_ax_multitask
…nsemble into release/v_1.5.0
…listed in advanced_installation
This reverts commit 877f52b.
…e attribute from the object. try the dynamic versioning again...
…ibensemble.gen_funcs.persistent_tasmanian import *
Replace flashing live animation with clean post-run version
Testing/some coverage + another attempt at dynamic versioning
Release/v 1.5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Python 3.9 dropped, many type hints can be modernized, e.g:
Optional[Union[int, float]]->int | float | NoneChanges were guided by
flake8-modern-annotationsandflake8-type-checking,which were added to the dev environment.
Addresses #1378