Skip to content

DAO: simplify proposal filters and align count badges - #1563

Merged
osyed merged 14 commits into
mainfrom
issue-1561-dao-proposal-filters
Aug 12, 2026
Merged

DAO: simplify proposal filters and align count badges#1563
osyed merged 14 commits into
mainfrom
issue-1561-dao-proposal-filters

Conversation

@dnlbui

@dnlbui dnlbui commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What Changed

This PR keeps the complete DAO proposal-filter set visible and aligns their count badges.

  • Removes the filter overflow container and expand/collapse control from the DAO modal.
  • Renders all eight filter chips in a shared four-column grid while preserving tab selection, proposal counts, headings, and accessible labels.
  • Simplifies the proposal detail presentation for options and vote-result meters, including compact deadline labels.

Fixed Flow

  1. Open the DAO modal.
  2. Every proposal state filter is immediately visible; no expansion control is required.
  3. Select a filter to update the active chip, heading, count, and proposal list.
  4. The fixed toolbar keeps filters available while the proposal list scrolls.

Why

The former overflow layout hid several proposal states behind an expand control. A shared grid makes the full state set immediately scannable and keeps badges consistently aligned across rows.

Validation

  • node --check app.js
  • node --test tests/dao-filter-layout.test.mjs
  • git diff --check 20ecbf42b3ee7920a2a69484bac78033ba41d655

Closes #1561

@dnlbui
dnlbui marked this pull request as ready for review August 11, 2026 20:25
@dnlbui dnlbui linked an issue Aug 11, 2026 that may be closed by this pull request
@osyed
osyed force-pushed the issue-1561-dao-proposal-filters branch from cdc8c38 to d70c618 Compare August 12, 2026 14:28
Base automatically changed from phase-5-dao-render-proposal-details to main August 12, 2026 14:32
@osyed
osyed force-pushed the issue-1561-dao-proposal-filters branch from d70c618 to 55a29ea Compare August 12, 2026 14:32
@osyed
osyed merged commit f5d25b3 into main Aug 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAO: simplify proposal filters and align count badges

2 participants