feat(dao): accept vote spend multiples - #1565
Merged
Merged
Conversation
dnlbui
marked this pull request as ready for review
August 11, 2026 22:10
dnlbui
force-pushed
the
issue-1515-vote-spend-multiple
branch
from
August 11, 2026 22:12
f54a4fd to
4643456
Compare
osyed
force-pushed
the
issue-1515-vote-spend-multiple
branch
from
August 12, 2026 14:28
2edd480 to
23e2176
Compare
dnlbui
marked this pull request as draft
August 12, 2026 14:29
osyed
force-pushed
the
issue-1515-vote-spend-multiple
branch
from
August 12, 2026 14:32
23e2176 to
9c655de
Compare
osyed
force-pushed
the
issue-1515-vote-spend-multiple
branch
from
August 12, 2026 14:38
9c655de to
9e0c67c
Compare
Base automatically changed from
issue-1562-dao-no-participation-outcomes
to
main
August 12, 2026 14:54
osyed
force-pushed
the
issue-1515-vote-spend-multiple
branch
from
August 12, 2026 14:54
9e0c67c to
b6fbe96
Compare
dnlbui
marked this pull request as ready for review
August 12, 2026 15:44
dnlbui
force-pushed
the
issue-1515-vote-spend-multiple
branch
from
August 12, 2026 15:44
bd62977 to
2e3a6c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR lets voters enter DAO vote spend as a positive whole-number multiple of the proposal's minimum spend instead of entering a raw LIB amount.
ProposalInfoModalconverts the selected multiple into the exact LIB spend using the proposal minimum and current network pricing.1and is revalidated before the vote transaction is signed.Fixed Flow
Why
Entering a raw LIB amount made voters calculate the proposal minimum themselves. Expressing spend as a minimum-spend multiple makes valid amounts easier to choose while preserving the server's existing
spendandweightstransaction fields.Validation
git diff --check 64a05aee0d66b0afb022676bce4297ac87e1656anode --check app.jsnode --check dao.jsFollow-up: #1568
Closes #1515