Skip to content

feat(dao): accept vote spend multiples - #1565

Merged
osyed merged 11 commits into
mainfrom
issue-1515-vote-spend-multiple
Aug 12, 2026
Merged

feat(dao): accept vote spend multiples#1565
osyed merged 11 commits into
mainfrom
issue-1515-vote-spend-multiple

Conversation

@dnlbui

@dnlbui dnlbui commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What Changed

This PR lets voters enter DAO vote spend as a positive whole-number multiple of the proposal's minimum spend instead of entering a raw LIB amount.

  • ProposalInfoModal converts the selected multiple into the exact LIB spend using the proposal minimum and current network pricing.
  • Option weights remain independent and continue to define the proportional allocation across proposal choices.
  • The preview shows the calculated spend, timing multiplier, total estimated voting power, and per-option allocation.
  • The spend multiple defaults to 1 and is revalidated before the vote transaction is signed.

Fixed Flow

  1. The voter assigns weights to one or more proposal options.
  2. The voter chooses a whole-number minimum-spend multiple.
  3. The client calculates and previews the resulting LIB spend and voting power.
  4. After confirmation, the client revalidates the inputs and submits the calculated spend with the independent option weights.

Why

Entering a raw LIB amount made voters calculate the proposal minimum themselves. Expressing spend as a minimum-spend multiple makes valid amounts easier to choose while preserving the server's existing spend and weights transaction fields.

Validation

  • git diff --check 64a05aee0d66b0afb022676bce4297ac87e1656a
  • node --check app.js
  • node --check dao.js
  • Client E2E GitHub check

Follow-up: #1568

Closes #1515

@dnlbui
dnlbui marked this pull request as ready for review August 11, 2026 22:10
@dnlbui
dnlbui force-pushed the issue-1515-vote-spend-multiple branch from f54a4fd to 4643456 Compare August 11, 2026 22:12
@osyed
osyed force-pushed the issue-1515-vote-spend-multiple branch from 2edd480 to 23e2176 Compare August 12, 2026 14:28
@dnlbui
dnlbui marked this pull request as draft August 12, 2026 14:29
@osyed
osyed force-pushed the issue-1515-vote-spend-multiple branch from 23e2176 to 9c655de Compare August 12, 2026 14:32
@osyed
osyed force-pushed the issue-1515-vote-spend-multiple branch from 9c655de to 9e0c67c Compare August 12, 2026 14:38
Base automatically changed from issue-1562-dao-no-participation-outcomes to main August 12, 2026 14:54
@osyed
osyed force-pushed the issue-1515-vote-spend-multiple branch from 9e0c67c to b6fbe96 Compare August 12, 2026 14:54
@dnlbui dnlbui changed the title feat(dao): combine vote spend multiples and allocations feat(dao): accept vote spend multiples Aug 12, 2026
@dnlbui
dnlbui marked this pull request as ready for review August 12, 2026 15:44
@dnlbui
dnlbui force-pushed the issue-1515-vote-spend-multiple branch from bd62977 to 2e3a6c4 Compare August 12, 2026 15:44
@osyed
osyed merged commit 8617362 into main Aug 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow vote spend amount as a multiple of minimum spend amount

2 participants